This repository was archived by the owner on Feb 25, 2026. It is now read-only.
Upgrade packages and node versions#118
Open
ingeniumed wants to merge 5 commits into
Open
Conversation
…xtjs-skeleton into update/all-packages
alecgeatches
approved these changes
Nov 2, 2023
alecgeatches
left a comment
alecgeatches
left a comment
Contributor
There was a problem hiding this comment.
Looks good to me! I'm surprised we're still using CircleCI here as we're mostly GitHub Actions most other places. Would it make sense to add a backlog item to move these over?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This will upgrade all the packages to the latest versions, and incorporates any fixes needed for them.
What I found:
extend-expecthas been removed so i dropped that part of the import. In case a replacement is needed, there is one I have in mind but I haven't used it. Check this out."@typescript-eslint/eslint-plugin": "^6.9.0"&"@typescript-eslint/parser": "^6.9.0",in order to ensure the underlying version used was correct. It was using 5.12 previously.In addition, it also updates the node versions to test against in the CircleCI config. That's set to Node 20 and Node 18. I can add Node 16 back if need be.