Es/r4 postgres by chullybun · Pull Request #143 · Avanade/CoreEx

chullybun · 2026-05-13T20:22:26Z

Introduce PostgreSQL
Merge others and confirm
Introduce CI

Packaging improvements.

Minor solution tweaks.

E2E testing uplift.

Copilot

Pull request overview

This PR introduces PostgreSQL support into CoreEx and migrates the Contoso Products sample from SQL Server to PostgreSQL, while also updating packaging, source generation, test setup, and solution filters for CI/build workflows.

Changes:

Added PostgreSQL database, unit-of-work, outbox publisher/relay, OpenTelemetry, and unit-test infrastructure.
Migrated Contoso Products database, infrastructure, hosts, and tests to PostgreSQL.
Updated packaging/signing/source-generator setup and added solution filters for core/sample build and test execution.

Reviewed changes

Copilot reviewed 229 out of 232 changed files in this pull request and generated 36 comments.

Show a summary per file

File	Description
`src/CoreEx.Database.Postgres/*`	Adds PostgreSQL database, outbox, unit-of-work, DI, telemetry, metrics, and parameter support.
`samples/src/Contoso.Products.*`	Migrates Products API, Subscribe, Outbox Relay, Database, and Infrastructure to PostgreSQL.
`samples/tests/Contoso.Products.*`	Updates Products tests to use PostgreSQL migrations and outbox expectations.
`tests/CoreEx.Database.Postgres.*`	Adds PostgreSQL database and EF CRUD/query/unit-of-work test coverage.
`src/CoreEx.Database/*`	Refactors database abstractions, parameters, scalar handling, outbox base behavior, and database columns.
`src/CoreEx.Database.SqlServer/*`	Adapts SQL Server implementation to new database abstractions and outbox publisher location.
`src/CoreEx.EntityFrameworkCore/Converters/*`	Renames/removes EF converters and adds a JsonElement EF converter.
`src/CoreEx.UnitTesting/*`	Adds PostgreSQL test helpers and refactors migration helper state.
`src/CoreEx/*`	Adds precision time provider, DI registration, strong-name/internal updates, and uint ETag converter.
`gen/CoreEx.Generator/*`	Updates generator packaging/signing and fixes template/source-generation behavior.
`Directory.Packages.props`	Adds PostgreSQL/Npgsql/DbEx package versions and generator signing dependency.
`src/Directory.Build.props`	Centralizes versioning, package metadata, signing, source/symbol packaging, and assets.
`src/CoreEx/CoreEx.csproj`	Bundles the source generator and analyzer dependencies into the CoreEx package.
`samples/src/Contoso.Orders.*`	Regenerates Orders persistence models and adjusts mapping/repository nullability.
`samples/src/Contoso.Shopping.*`	Adds precision time provider and SQL Server EF connection ownership changes.
`samples/tests/Contoso.E2E.Runner/*`	Updates Products migration to PostgreSQL and adds Orders API status/configuration.
`tests/CoreEx.Azure.Messaging.ServiceBus.Test.Unit/*`	Adjusts Service Bus cleanup timing and circuit-breaker test retry behavior.
`tests/CoreEx.Caching.Redis.Test.Unit/*`	Updates cache log expectation and disables TFM-parallel execution.
`tests/CoreEx.Database.SqlServer.Test.Unit/*`	Updates SQL Server tests for connection ownership/converters and sequential TFM execution.
`tests/CoreEx.Validation.Test.Unit/ValidatorTests.cs`	Makes currency-format validation culture-stable.
`tests/CoreEx.RefData.Test.Unit/ReferenceDataOrchestratorTests.cs`	Adds a reference-data code collection source-generation test type.
`samples/aspire/Contoso.Aspire/AppHost.cs`	Reorganizes sample Aspire host declarations.
`CoreEx.*.slnf`	Adds solution filters for core/sample build and test workflows.
`.config/dotnet-tools.json`	Adds report generator local tool manifest.
`nuget-publish.ps1`	Updates package publish project list.

Comments suppressed due to low confidence (7)

src/CoreEx.UnitTesting/UnitTestExExtensions.Postgres.cs:52

Typo in the remarks: “isued” should be “issued”.
src/CoreEx.UnitTesting/UnitTestExExtensions.SqlServer.cs:52
Typo in the remarks: “isued” should be “issued”.
samples/src/Contoso.Products.Outbox.Relay/Contoso.Products.Outbox.Relay.http:8
The hosted-service key is registered as postgres-outbox-relay-00, but this sample request uses Postgres-outbox-relay-00. Use the registered lowercase key so the copied request targets the actual hosted service.
samples/src/Contoso.Products.Outbox.Relay/Contoso.Products.Outbox.Relay.http:12
The hosted-service key is registered as postgres-outbox-relay-00, but this sample request uses Postgres-outbox-relay-00. Use the registered lowercase key so the copied request targets the actual hosted service.
samples/src/Contoso.Products.Database/Migrations/20260101-000301-create-products-outbox-tables.pgsql:29
The column is declared NOT NULL and the lease functions use '(none)' for non-tenant events, so the comment saying “null indicates no tenancy” is inaccurate. Update it to describe the actual sentinel value.
src/CoreEx.EntityFrameworkCore/Converters/StringBase64Converter.cs:1
Removing this public EF converter is a source-breaking change for consumers that reference CoreEx.EntityFrameworkCore.Converters.StringBase64Converter directly. If the replacement is ValueConverterBridge.Create(...StringBase64Converter.Default), keep a compatibility shim or document the breaking API change.
src/CoreEx.EntityFrameworkCore/Converters/JsonElementStringConverter.cs:1
Renaming/removing this public converter breaks consumers that reference CoreEx.EntityFrameworkCore.Converters.JsonElementStringConverter directly. Consider keeping a forwarding compatibility type that derives from the new JsonElementStringEfConverter, or document the breaking API change.

Copilot

Pull request overview

Copilot reviewed 236 out of 239 changed files in this pull request and generated 33 comments.

Comments suppressed due to low confidence (2)

src/CoreEx.EntityFrameworkCore/Converters/StringBase64Converter.cs:1

Deleting this public EF converter removes CoreEx.EntityFrameworkCore.Converters.StringBase64Converter from the package, which will break consumers mapping row-version/ETag properties with the existing type. Consider keeping it as an obsolete wrapper around ValueConverterBridge for source compatibility.
samples/src/Contoso.Orders.Database/Schema/Stored Procedures/spOutboxBatchComplete.g.sql:54
@TenantId and @PartitionId are assigned from @Completed but never used afterward. This adds unnecessary work and makes the procedure look like the values affect lease release when they do not.

    -- 2) Capture tenant/partition from first completed row.
    SELECT TOP 1
      @TenantId = TenantId,
      @PartitionId = PartitionId
    FROM @Completed;

Copilot

Pull request overview

Copilot reviewed 237 out of 240 changed files in this pull request and generated 14 comments.

Comments suppressed due to low confidence (2)

src/CoreEx.EntityFrameworkCore/Converters/StringBase64Converter.cs:1

Removing this public converter type is a source-breaking change for any consumer that configures EF mappings with CoreEx.EntityFrameworkCore.Converters.StringBase64Converter.Default. Keep a compatibility wrapper (possibly obsolete) or document and coordinate the breaking API change.
src/CoreEx.EntityFrameworkCore/Converters/JsonElementStringConverter.cs:1
This removes the existing public JsonElementStringConverter API and replaces it with a differently named type, which will break consumers that already reference the old EF converter in their model configuration. Consider leaving an obsolete wrapper that derives from/forwards to JsonElementStringEfConverter to preserve source compatibility.

        string[] _requiredServices =
        [
-            "sqlServer",
-            "sqlserver-outbox-relay-00",
-            "sqlserver-outbox-relay-01",
-            "sqlserver-outbox-relay-02",
-            "sqlserver-outbox-relay-03"
+            "postgres",
+            "postgres-outbox-relay-00",


+public sealed class PrecisionTimeProvider(int decimalPlaces = 6, TimeProvider? innerProvider = null) : TimeProvider
+{
+    private readonly TimeProvider _innerProvider = innerProvider ?? System;
+    private readonly int _decimalPlaces = decimalPlaces >= 0 && decimalPlaces <= 7 ? decimalPlaces : throw new ArgumentOutOfRangeException(nameof(decimalPlaces), "Must be between 0 and 7.");
+    private readonly long _tickDivisor = (long)Math.Pow(10, 7 - decimalPlaces);


+public readonly struct EncodedStringToUInt32Converter : IConverter<string?, uint>
+{
+    private static readonly ValueConverter<string?, uint> _convertToDestination = new(s => s == null ? 0 : BitConverter.ToUInt32(Convert.FromBase64String(s)));
+    private static readonly ValueConverter<uint, string?> _convertToSource = new(d => d == 0 ? null : Convert.ToBase64String(BitConverter.GetBytes(d)));


Copilot

Pull request overview

Copilot reviewed 237 out of 240 changed files in this pull request and generated 9 comments.

Comments suppressed due to low confidence (2)

tests/CoreEx.Database.Postgres.Test.Console/Data/data.yaml:12

This row also seeds the PostgreSQL boolean is_deleted column with numeric 1. Use the boolean literal true to avoid type errors during PostgreSQL data loading.
src/CoreEx.Database/SqlStatement.cs:62
This XML comment also refers to SqlStatement as a struct after the type was changed to a class; update it so generated API docs match the implementation.

Copilot

Copilot encountered an error and was unable to review this pull request. You can try again by re-requesting a review.

chullybun added 22 commits May 5, 2026 10:53

CoreEx.Database.Postgres project introduction.

d360ef2

Refactor Products sample to leverage PostgreSQL.

62c9864

Update to use interim schema for dbex yaml.

cf13ff3

Generator fixes.

a6521c0

Packaging improvements.

DbEx finalized version.

e403d5f

Minor solution tweaks.

Merge from latest release/4

61775ff

Orders merge, and refactor/regen.

8ff2688

E2E testing uplift.

CI.yml added.

1124aa7

Fix CI.yml

660f24b

Add slnf files to aid CI.

491684d

Further tweaks to CI and test fix.

1eac786

CI fix.

a6f6c26

Split parrallel and sequential for core to improve perf.

00b2b66

Test fixes.

ba40c56

Add retry to CircuitBreaker test.

6f7b9a2

Fix parallelism for samples.

016a67b

Another parallelism fix.

41ec4f9

Another parallelism fix attemp?!

e435504

Another parallelism crack :-(

c655f51

Fix async bug.

0f50ce8

NUnit result fix for retry.

43cf54a

Another CI fix.

8e70b7c

Copilot AI review requested due to automatic review settings May 13, 2026 20:22

Copilot started reviewing on behalf of chullybun May 13, 2026 20:23 View session

Copilot AI reviewed May 13, 2026

View reviewed changes

chullybun added 2 commits May 14, 2026 13:01

Fixes related to PR comments.

df67899

Re-gen sql procs.

83fcc75

Copilot AI review requested due to automatic review settings May 14, 2026 20:16

Copilot started reviewing on behalf of chullybun May 14, 2026 20:17 View session

Copilot AI reviewed May 14, 2026

View reviewed changes

chullybun added 2 commits May 14, 2026 14:46

Tweaks based on review.

9c515a0

Puch CI tweak.

0ec9a7d

Copilot AI review requested due to automatic review settings May 14, 2026 22:30

Copilot started reviewing on behalf of chullybun May 14, 2026 22:30 View session

Another CI tweak.

59f058c

Copilot AI reviewed May 14, 2026

View reviewed changes

chullybun added 2 commits May 14, 2026 16:06

Sneak last - link to DTS from Aspire dashboard.

3702362

Wrap up tweaks.

055a64c

Copilot AI review requested due to automatic review settings May 15, 2026 20:47

Copilot started reviewing on behalf of chullybun May 15, 2026 20:48 View session

Copilot AI reviewed May 15, 2026

View reviewed changes

chullybun added 2 commits May 15, 2026 14:23

CI tweak.

533eb8b

Review feedback tweaks.

fdbc56e

Copilot AI review requested due to automatic review settings May 18, 2026 16:19

Copilot started reviewing on behalf of chullybun May 18, 2026 16:20 View session

Copilot AI reviewed May 18, 2026

chullybun merged commit 37b52bc into release/4 May 18, 2026
4 of 5 checks passed

chullybun deleted the es/r4-postgres branch May 18, 2026 17:09

Conversation

chullybun commented May 13, 2026

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Reviewed changes

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Pull request overview

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

2 participants