feat(hyprland): add mirrorOf member of Monitor#305
Open
Dr0med4r wants to merge 2 commits intoAylur:mainfrom
Open
feat(hyprland): add mirrorOf member of Monitor#305Dr0med4r wants to merge 2 commits intoAylur:mainfrom
Dr0med4r wants to merge 2 commits intoAylur:mainfrom
Conversation
For this it is necessary to use "monitors all" and not "monitors" if this is not done the monitoradded event will add an empty monitor and the monitorremoved event will fail with a null error.
Aylur
reviewed
Mar 3, 2025
Aylur
reviewed
Mar 3, 2025
This is null if the monitor is not mirrored or mirrorOf is not yet implemented else it is the monitor mirrored.
Contributor
Author
|
Should there be a distinction between "hyprland before 0.45" and "not mirrored"? |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For this, it is necessary to use 'monitors all' instead of 'monitors.'
If this is not done, the 'monitoradded' event will add an empty monitor, and the 'monitorremoved' event will fail with a null error.
This fixes issues with mirrored displays, but now mirrored monitors are listed under 'monitors' (which they previously were, but not fully and I don't know if this is intended behaviour).