Merged
Conversation
Co-authored-by: Copilot <copilot@github.com>
…ering Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…pe preview visuals Co-authored-by: Copilot <copilot@github.com>
… smoother coastline curves
✅ Deploy Preview for afmg ready!
To edit notification comments on pull requests, go to your Netlify project configuration. |
Contributor
There was a problem hiding this comment.
Pull request overview
This PR introduces a fractal-based coastline renderer (“jagged coastline”) and wires in a small UI editor to tweak coastline roughness parameters at runtime, changing how feature polygons (coastlines/islands/lakes) are converted into SVG paths.
Changes:
- Added a new coastline fractalization module that subdivides polygon edges and generates mixed smooth/jagged SVG path segments.
- Updated feature rendering to use the new fractalized coastline path builder instead of
d3’scurveBasisClosed. - Added a coastline settings dialog (sliders + previews) and adjusted default sea island stroke width.
Reviewed changes
Copilot reviewed 5 out of 5 changed files in this pull request and generated 7 comments.
Show a summary per file
| File | Description |
|---|---|
| src/renderers/index.ts | Loads the new coastline editor/controller and coastline fractal module via side-effect imports. |
| src/renderers/draw-features.ts | Switches feature path generation to fractalized coastline shapes + custom path builder. |
| src/renderers/coastline-fractal.ts | New fractalization + path construction logic for “jagged coastline” rendering. |
| src/controllers/coastline-editor.ts | New UI dialog to edit coastline parameters and preview roughness/shape. |
| public/styles/default.json | Tweaks default #sea_island stroke width to match new coastline visuals. |
…zation logic Co-authored-by: Copilot <copilot@github.com>
…imize variable declaration Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
Co-authored-by: Copilot <copilot@github.com>
…dialog title Co-authored-by: Copilot <copilot@github.com>
…talization logic Co-authored-by: Copilot <copilot@github.com>
…htmap editor features Co-authored-by: Copilot <copilot@github.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.