Conversation
@microsoft-github-policy-service agree company="Panorays" |
99e44c6 to
b541ea9
Compare
|
BasePath Format: and Please refer to the CCF solution provided below and ensure the files are renamed as per the solution. https://github.com/Azure/Azure-Sentinel/tree/master/Solutions/Cloudflare%20CCF Thanks! |
|
Hi @v-maheshbh , |
|
Kindly update the logo path in the data file to align with the master branch. Please refer to an existing solution for reference. thanks! |
|
Hi, Done |
|
Hi team, |
|
Kindly attach a testing screenshot of the CCF data connector in the connected state for reference. Thanks! |
There was a problem hiding this comment.
Pull request overview
Adds a new Panorays solution scaffold to the repository, including the solution metadata, solution data manifest, and initial release notes.
Changes:
- Added
Solutions/Panorays/SolutionMetadata.jsonto define solution identity, versions, publisher/offer info, and support metadata. - Added
Solutions/Panorays/Data/Solution_Panorays.jsonandSolutions/Panorays/ReleaseNotes.mdto describe packaged assets and release history. - (Changes under
Solutions/**/Data Connectors/**andSolutions/**/Package/**are present but intentionally not reviewed per repo guidance.)
Reviewed changes
Copilot reviewed 13 out of 14 changed files in this pull request and generated 8 comments.
Show a summary per file
| File | Description |
|---|---|
| Solutions/Panorays/SolutionMetadata.json | Introduces core solution metadata (name/IDs/version/publisher/support/categories). |
| Solutions/Panorays/ReleaseNotes.md | Adds initial release notes entry for the solution. |
| Solutions/Panorays/Package/testParameters.json | Not reviewed (ignored path: Solutions/**/Package/**). |
| Solutions/Panorays/Package/mainTemplate.json | Not reviewed (ignored path: Solutions/**/Package/**). |
| Solutions/Panorays/Package/createUiDefinition.json | Not reviewed (ignored path: Solutions/**/Package/**). |
| Solutions/Panorays/Data/Solution_Panorays.json | Adds the solution “manifest” describing included assets and packaging flags. |
| Solutions/Panorays/Data Connectors/requirements.txt | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| Solutions/Panorays/Data Connectors/Panorays_CCF/createUiDefinition.json | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| Solutions/Panorays/Data Connectors/Panorays_CCF/Panorays_table.json | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| Solutions/Panorays/Data Connectors/Panorays_CCF/Panorays_connectorDefinition.json | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| Solutions/Panorays/Data Connectors/Panorays_CCF/Panorays_PollerConfig.json | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| Solutions/Panorays/Data Connectors/Panorays_CCF/Panorays_DCR.json | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| Solutions/Panorays/Data Connectors/Panorays_CCF/DeployInstance.json | Not reviewed (ignored path: Solutions/**/Data Connectors/**). |
| "offerId": "azure-sentinel-solution-panprays", | ||
| "PackageId": "azuresentinel.azure-sentinel-panprays", |
There was a problem hiding this comment.
The offerId / PackageId values contain a likely typo (panprays vs panorays). These IDs are used for publishing/packaging and should match the solution name/folder consistently (e.g., ...-panorays). Update both fields to the correct, consistent identifier.
| "offerId": "azure-sentinel-solution-panprays", | |
| "PackageId": "azuresentinel.azure-sentinel-panprays", | |
| "offerId": "azure-sentinel-solution-panorays", | |
| "PackageId": "azuresentinel.azure-sentinel-panorays", |
| { | ||
| "SolutionName":"Panorays", | ||
| "SolutionAuthor": "Microsoft", | ||
| "SolutionVersion":"1.0.0", |
There was a problem hiding this comment.
The solution version in SolutionMetadata.json (1.0.0) conflicts with the version used elsewhere in this PR (e.g., Solutions/Panorays/Data/Solution_Panorays.json and Solutions/Panorays/ReleaseNotes.md show 3.0.0). Use a single, consistent solution/package version across solution metadata, solution data, and release notes to avoid validation and packaging inconsistencies.
| "SolutionVersion":"1.0.0", | |
| "SolutionVersion":"3.0.0", |
|
Recently, SolutionMetadata was modified. Kindly repackage the solution so the updates are reflected in mainTemplate.json. "BasePath": "C:\GitHub\Azure-Sentinel\solutions\Panorays" this is correct path. Thanks! |
|
Hello @v-maheshbh , Thank you for the feedback. I have updated the PR with the following changes to align with the latest Microsoft Sentinel solution requirements. Many Thanks and best regards, |
|
Kindly rename the file ccpPanoraysCompanyFindingPOC.json to Panorays_ConnectorDefinition.json and update the same in the data file accordingly. Thanks! |
|
Thank you @v-maheshbh. I have addressed all the feedback: |
|
Invalid domains: [Security - Other] provided. Thanks! |
|
Thank you for the clarification, @v-maheshbh |


Required items, please complete
Change(s):
Reason for Change(s):
Version Updated:
Testing Completed:
Checked that the validations are passing and have addressed any issues that are present: