Skip to content

[Network] az network private-endpoint: Add --billing-sku - #33799

Draft
Jian Hui (huiii99) wants to merge 5 commits into
Azure:devfrom
huiii99:feat/private-endpoint-upgrade
Draft

[Network] az network private-endpoint: Add --billing-sku#33799
Jian Hui (huiii99) wants to merge 5 commits into
Azure:devfrom
huiii99:feat/private-endpoint-upgrade

Conversation

@huiii99

@huiii99 Jian Hui (huiii99) commented Jul 28, 2026

Copy link
Copy Markdown
Member

🤖 PR Validation — ❌ Action needed

Breaking Changes Tests
❌ 1 ️✔️ 130/130
❌AzureCLI-BreakingChangeTest
❌network
rule cmd_name rule_message suggest_message
1007 - ParaRemove network private-endpoint show cmd network private-endpoint show removed parameter expand please add back parameter expand for cmd network private-endpoint show
1007 - ParaRemove network private-endpoint wait cmd network private-endpoint wait removed parameter expand please add back parameter expand for cmd network private-endpoint wait
⚠️ 1006 - ParaAdd network private-endpoint create cmd network private-endpoint create added parameter billing_sku
⚠️ 1006 - ParaAdd network private-endpoint update cmd network private-endpoint update added parameter billing_sku

Please submit your Breaking Change Pre-announcement ASAP if you haven't already. Please note:

  • Breaking changes can only be merged during the designated breaking change window
  • A pre-announcement must be released at least one month in advance

For more details on how to introduce breaking changes, refer to the documentation: azure-cli/doc/how_to_introduce_breaking_changes.md

Related command
az network private-endpoint create/update/show/list

Description
Upgrade the az network private-endpoint command group to API version 2025-07-01.

  • Add --billing-sku to create/update to configure the private endpoint billing SKU.
  • Remove --expand from show/list, as it is no longer supported by the 2025-07-01 API.
  • Regenerate the affected AAZ commands and update the impacted test recordings for the new API version.

aaz Azure/aaz#1051

Testing Guide
azdev test test_network_private_endpoint_billing_sku --live

History Notes
[Network] az network private-endpoint create/update: Add --billing-sku to configure the private endpoint billing SKU
[Network] BREAKING CHANGE: az network private-endpoint show/list: Remove --expand, no longer supported by API version 2025-07-01


This checklist is used to make sure that common guidelines for a pull request are followed.

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
There may be pipelines that require an authorized user to comment /azp run to run.

@a0x1ab

Copy link
Copy Markdown
Member

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

@x-engineering-agent

Copy link
Copy Markdown
Contributor

Live test results — azdev test --live --series (changed test files only)

FAIL (exit 1)

Selectors: test_network_commands (module)
PR head ref: feat/private-endpoint-upgrade
PR head sha: 6e48659e77e9305bd2155d6006b6705b6b95eb8e
PR base ref: dev
New test files in PR: false

Changed test files run
src/azure-cli/azure/cli/command_modules/network/tests/latest/test_network_commands.py

Workflow run: https://github.com/Azure/issue-sentinel/actions/runs/32231124504

Live-test recordings: 4 regenerated — archived in workflow artifact live-test-pr-33799 (recordings/).

ℹ️ This PR is from a fork, so recordings were not pushed automatically. Download them from the artifact and commit to your branch.

Recording files
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_asg.yaml
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_lb_sku.yaml
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_private_endpoint_asg.yaml
src/azure-cli/azure/cli/command_modules/network/tests/latest/recordings/test_network_private_endpoint_ip_config.yaml
Last 80 lines of azdev output
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
.venv/lib/python3.12/site-packages/azure/core/tracing/decorator.py:119: in wrapper_use_tracer
    return func(*args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^
_ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ _ 

self = <azure.mgmt.resource.resources.v2024_11_01.operations._operations.ResourceGroupsOperations object at 0x7fde92031ee0>
resource_group_name = 'fanqiu_cli_test_network_private_endpoints5umlnrv2zdhtw35whcbpcrwciovyot4zl2'
parameters = <azure.mgmt.resource.resources.v2024_11_01.models._models_py3.ResourceGroup object at 0x7fde920820f0>
kwargs = {}

    @distributed_trace
    def create_or_update(
        self, resource_group_name: str, parameters: Union[_models.ResourceGroup, IO[bytes]], **kwargs: Any
    ) -> _models.ResourceGroup:
        """Creates or updates a resource group.
    
        :param resource_group_name: The name of the resource group to create or update. Can include
         alphanumeric, underscore, parentheses, hyphen, period (except at end), and Unicode characters
         that match the allowed characters. Required.
        :type resource_group_name: str
        :param parameters: Parameters supplied to the create or update a resource group. Is either a
         ResourceGroup type or a IO[bytes] type. Required.
        :type parameters: ~azure.mgmt.resource.resources.v2024_11_01.models.ResourceGroup or IO[bytes]
        :return: ResourceGroup or the result of cls(response)
        :rtype: ~azure.mgmt.resource.resources.v2024_11_01.models.ResourceGroup
        :raises ~azure.core.exceptions.HttpResponseError:
        """
        error_map: MutableMapping = {
            401: ClientAuthenticationError,
            404: ResourceNotFoundError,
            409: ResourceExistsError,
            304: ResourceNotModifiedError,
        }
        error_map.update(kwargs.pop("error_map", {}) or {})
    
        _headers = case_insensitive_dict(kwargs.pop("headers", {}) or {})
        _params = case_insensitive_dict(kwargs.pop("params", {}) or {})
    
        api_version: str = kwargs.pop("api_version", _params.pop("api-version", self._api_version or "2024-11-01"))
        content_type: Optional[str] = kwargs.pop("content_type", _headers.pop("Content-Type", None))
        cls: ClsType[_models.ResourceGroup] = kwargs.pop("cls", None)
    
        content_type = content_type or "application/json"
        _json = None
        _content = None
        if isinstance(parameters, (IOBase, bytes)):
            _content = parameters
        else:
            _json = self._serialize.body(parameters, "ResourceGroup")
    
        _request = build_resource_groups_create_or_update_request(
            resource_group_name=resource_group_name,
            subscription_id=self._config.subscription_id,
            api_version=api_version,
            content_type=content_type,
            json=_json,
            content=_content,
            headers=_headers,
            params=_params,
        )
        _request.url = self._client.format_url(_request.url)
    
        _stream = False
        pipeline_response: PipelineResponse = self._client._pipeline.run(  # pylint: disable=protected-access
            _request, stream=_stream, **kwargs
        )
    
        response = pipeline_response.http_response
    
        if response.status_code not in [200, 201]:
            map_error(status_code=response.status_code, response=response, error_map=error_map)
>           raise HttpResponseError(response=response, error_format=ARMErrorFormat)
E           azure.core.exceptions.HttpResponseError: (LocationNotAvailableForResourceGroup) The provided location 'CentralUSEuap' is not available for resource group. List of available regions is 'eastasia,southeastasia,austriaeast,australiaeast,australiacentral,australiacentral2,australiasoutheast,belgiumcentral,brazilsouth,canadacentral,canadaeast,switzerlandnorth,chilecentral,denmarkeast,germanywestcentral,eastus2,eastus,centralus,northcentralus,francecentral,uksouth,ukwest,indonesiacentral,israelcentral,centralindia,southindia,jioindiawest,italynorth,japaneast,japanwest,koreacentral,koreasouth,malaysiawest,mexicocentral,northeurope,norwayeast,newzealandnorth,polandcentral,qatarcentral,spaincentral,swedencentral,uaenorth,westcentralus,westeurope,westus2,westus,southcentralus,westus3,southafricanorth,westindia,jioindiacentral,indiasouthcentral'.
E           Code: LocationNotAvailableForResourceGroup
E           Message: The provided location 'CentralUSEuap' is not available for resource group. List of available regions is 'eastasia,southeastasia,austriaeast,australiaeast,australiacentral,australiacentral2,australiasoutheast,belgiumcentral,brazilsouth,canadacentral,canadaeast,switzerlandnorth,chilecentral,denmarkeast,germanywestcentral,eastus2,eastus,centralus,northcentralus,francecentral,uksouth,ukwest,indonesiacentral,israelcentral,centralindia,southindia,jioindiawest,italynorth,japaneast,japanwest,koreacentral,koreasouth,malaysiawest,mexicocentral,northeurope,norwayeast,newzealandnorth,polandcentral,qatarcentral,spaincentral,swedencentral,uaenorth,westcentralus,westeurope,westus2,westus,southcentralus,westus3,southafricanorth,westindia,jioindiacentral,indiasouthcentral'.

.venv/lib/python3.12/site-packages/azure/mgmt/resource/resources/v2024_11_01/operations/_operations.py:5922: HttpResponseError
!!!!!!!!!!!!!!!!!!!!!!!!!! stopping after 1 failures !!!!!!!!!!!!!!!!!!!!!!!!!!!
=================== 1 failed, 4 passed in 484.74s (0:08:04) ====================

Posted by agent-assist live-test workflow.

@x-engineering-agent x-engineering-agent Bot left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

CI Summary

Live test: ❌ failed

Upstream CI: ❌ 3 checks failed.

Check Result
Azure.azure-cli Full Test failed — Build #20260728.6 had test failures
Automation Full Test Python312 Profile Latest instance1 failed
Automation Full Test Python314 Profile Latest instance1 failed

Please investigate the live-test failure and the full-test failures and push a fix.

@a0x1ab

Copy link
Copy Markdown
Member

Copilot resolve the merge conflicts in this pull request

@a0x1ab

Copy link
Copy Markdown
Member

Jian Hui (@huiii99) Can you please confirm if this PR is ready for this milestone as it is still in draft state?

@a0x1ab Aditya Pujara (a0x1ab) added X Engineering Agent Reviewed Pull request reviewed by X Engineering Agent and removed azure-client-tools-agent labels Sep 2, 2026
@microsoft-github-policy-service

Copy link
Copy Markdown
Contributor

🔔 Routing this PR to @Azure/act-quality-productivity-squad.

@huiii99

Copy link
Copy Markdown
Member Author

Jian Hui (Jian Hui (@huiii99)) Can you please confirm if this PR is ready for this milestone as it is still in draft state?

sorry for overlooking this message, this feature is not yet complete and will be released in the next version. Thank you!

@yonzhan Yong Zhang (yonzhan) added this to the Backlog milestone Sep 4, 2026
@huiii99

Copy link
Copy Markdown
Member Author

/azp run

@azure-pipelines

Copy link
Copy Markdown
Azure Pipelines:
Successfully started running 3 pipeline(s).

Copilot-Session: d9036981-89a0-44a3-b795-00732e37db75
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

act-quality-productivity-squad Auto-Assign Auto assign by bot Network az network vnet/lb/nic/dns/etc... X Engineering Agent Reviewed Pull request reviewed by X Engineering Agent

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants