{Agent} Add repository-owned X agent policy - #34028
Merged
Aditya Pujara (a0x1ab) merged 2 commits intoSep 4, 2026
Merged
Conversation
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: da851f42-f383-454b-83ea-398b7c4c972a
Contributor
There was a problem hiding this comment.
🟡 Changes recommended
The coordinator policy references invoke_repository_skill but the manifest skill allowlist does not include it, creating an enforceable mismatch in the declared least-privilege configuration.
Once you've addressed the issues Copilot identified, you can request another Copilot review.
Pull request overview
Adds a repository-owned “X agent” policy set under .x/ to define which agent roles are permitted and which base skills are allowlisted for least-privilege operation in Azure/azure-cli.
Changes:
- Introduces a trusted
.x/x.ymlmanifest enumerating permitted agents and an explicit skill allowlist. - Adds role policy documents for coordinator, fixer, tester, and reviewer behaviors and safety constraints.
- Documents custom-skill conventions in
.x/skills/README.md(one public top-level function per Python file; markdown is non-executable).
File summaries
| File | Description |
|---|---|
.x/x.yml |
Adds the repository-owned manifest defining agents and the base-skill allowlist. |
.x/coordinator.md |
Defines coordinator routing priorities and delegation rules for role loading/writes. |
.x/fixer.md |
Defines issue triage/requirements gating and routing between core vs extension work. |
.x/tester.md |
Defines live-test dispatch and reuse rules, restricting execution to approved workflow. |
.x/reviewer.md |
Defines evidence gates and review workflow, including Copilot-iteration handling. |
.x/skills/README.md |
Documents repository custom-skill structure and mapping requirements. |
Review details
- Files reviewed: 6/6 changed files
- Comments generated: 1
- Review effort level: Lite
💡 Add a code-review agent skill or configure MCP servers for context-aware, tailored reviews. Learn more in the docs.
Comment on lines
+6
to
+9
| skills: | ||
| - auto_trigger_pr_validation | ||
| - build_promoted_pr_body | ||
| - changed_test_files |
Co-authored-by: Copilot <223556219+Copilot@users.noreply.github.com> Copilot-Session: da851f42-f383-454b-83ea-398b7c4c972a
Yong Zhang (yonzhan)
requested review from
Yu Chen (jsntcy) and
ZelinWang (wangzelin007)
September 3, 2026 22:56
Collaborator
|
Agent |
ZelinWang (wangzelin007)
approved these changes
Sep 4, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
🤖 PR Validation — ️✔️ All clear
Related command
Not applicable
Description
Add the trusted repository-owned
.x/x.ymlmanifest with an explicit least privilege skill allowlist. Define coordinator, fixer, tester and reviewer policies.Testing Guide
Load every approved agent through the central trusted policy loader and verify that the manifest uses no wildcard capabilities.
History Notes
This checklist is used to make sure that common guidelines for a pull request are followed.
The PR title and description has followed the guideline in Submitting Pull Requests.
I adhere to the Command Guidelines.
I adhere to the Error Handling Guidelines.