[EngSys] Exclude compiler attribute from API Compat#58105
Open
[EngSys] Exclude compiler attribute from API Compat#58105
Conversation
The focus of these changes is to add the `Microsoft.Cci.DummyTypeReference` compiler attribute to the exclusion list for API Compat checks. This attribute is applied for scenarios such as type forwarding where there is unresolved information that is handled later and does not have any impact to the public API nor developer experience using the library.
Contributor
There was a problem hiding this comment.
Pull request overview
Adds Microsoft.Cci.DummyTypeReference to the central ApiCompat “exclude attributes” list so this compiler/CCI placeholder type does not surface as a public-API-affecting attribute during compatibility checks (notably in type-forwarding/unresolved-metadata scenarios).
Changes:
- Extend the ApiCompat excluded-attributes list to include
T:Microsoft.Cci.DummyTypeReference.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
The focus of these changes is to add the
Microsoft.Cci.DummyTypeReferencecompiler attribute to the exclusion list for API Compat checks. This attribute is applied for scenarios such as type forwarding where there is unresolved information that is handled later and does not have any impact to the public API nor developer experience using the library.