Skip to content

adding timeout to the rollout status - #353

Closed
Vidya2606 wants to merge 5 commits into
Azure:mainfrom
Vidya2606:addTimeoutInRolloutStatus
Closed

adding timeout to the rollout status#353
Vidya2606 wants to merge 5 commits into
Azure:mainfrom
Vidya2606:addTimeoutInRolloutStatus

Conversation

@Vidya2606

@Vidya2606 Vidya2606 commented Nov 19, 2024

Copy link
Copy Markdown
Contributor

Adding timeout to the rollout status - #350

@Vidya2606
Vidya2606 requested a review from a team as a code owner November 19, 2024 23:24
@davidgamero

davidgamero commented Nov 20, 2024

Copy link
Copy Markdown
Collaborator

this looks good.
let's add the input to action.yaml so it can be configured by users
this means it will be retrieved in run.ts via core.getInput and then passed down to the functions that use it.

also, let's default to a longer default timeout input in action.yaml like 10m

@davidgamero davidgamero left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@benjaminbob21

Copy link
Copy Markdown
Contributor

I will be closing this PR as there is another PR #425 that fixes this same issue, thanks for the initial implementation @Vidya2606.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants