Add GCU apply-patch performance smoke test for 202405#1227
Merged
yejianquan merged 1 commit intoJun 6, 2026
Conversation
Add a platform-agnostic performance regression test for GCU apply-patch. The test dynamically calibrates timing budgets based on the platform's measured loadData() cost, so it works correctly across different hardware without hard-coded timeouts. Test scenarios: 1. ACL port removal (REPLACE -> N REMOVE moves) - primary O(N^2) case 2. ACL table addition (single ADD move) 3. ACL rules addition (multiple nested ADD moves) 4. Multi-operation patch (ADD + REPLACE + REMOVE combined) 5. NTP server changes (simple scalar baseline) 6. Port MTU replace (REPLACE on existing entries) Budget formula: budget = calibrated_overhead + expected_moves * loads_per_move * measured_loaddata_time * safety_multiplier The test creates a checkpoint before running and rolls back after, leaving no persistent config changes on the device. Signed-off-by: Rithvick Reddy Munagala <rimunagala@microsoft.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Add a platform-agnostic performance regression test for GCU apply-patch. The test dynamically calibrates timing budgets based on the platform's measured loadData() cost, so it works correctly across different hardware without hard-coded timeouts.
Test scenarios:
Budget formula:
budget = calibrated_overhead + expected_moves * loads_per_move * measured_loaddata_time * safety_multiplier
The test creates a checkpoint before running and rolls back after, leaving no persistent config changes on the device.