Add linter rule `arm-post-lro-response-mismatch` for ARM POST LRO operations by Copilot · Pull Request #4145 · Azure/typespec-azure

Copilot · 2026-03-28T00:32:16Z

💡 You can make Copilot smarter by setting up custom instructions, customizing its development environment and configuring Model Context Protocol (MCP) servers. Learn more Copilot coding agent tips in the docs.

…tions Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

…-lro-response-mismatch Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

markcowl

@copilot Pull the latest from main and then apply the fixes in the comments. Ensure that all tests pass and all files are correctly formatted.

packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts

packages/typespec-azure-resource-manager/test/rules/arm-post-lro-response-mismatch.test.ts

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/52cf9dab-ba01-4457-92cd-cd8badcefa7d Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-03-31T18:53:46Z

@copilot Pull the latest from main and then apply the fixes in the comments. Ensure that all tests pass and all files are correctly formatted.

Pulled latest from main, applied all review fixes, and verified all 286 tests pass with correct formatting. Changes in a9c28e6.

markcowl · 2026-03-31T19:59:51Z

@copilot Please pull the latest from main, regenrate docs for tyepspec-azure-resource-manager, validate that all files are correctly formatted.

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f4c32a71-7b4b-4f80-ba9b-5ba00fbfab8b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-03-31T20:06:58Z

@copilot Please pull the latest from main, regenrate docs for tyepspec-azure-resource-manager, validate that all files are correctly formatted.

Pulled latest from main (already up to date at a228fc5), regenerated docs for typespec-azure-resource-manager (added the new rule to README.md and linter.md), validated formatting, and confirmed all 286 tests pass. Done in 7e87831.

markcowl

Please pull the latest from main, make the changes suggested, ensure all tests are passing and all files are correctly formatted.

packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts

…finalResult Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/1f249f2b-9ceb-48a6-ba20-2449bb561b02 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-03-31T20:24:32Z

Please pull the latest from main, make the changes suggested, ensure all tests are passing and all files are correctly formatted.

Pulled latest from main (already up to date), added the fallback for non-template operations that checks the 200 response body vs final-result-schema, and verified all 288 tests pass with correct formatting. Done in fcb4809.

Copilot · 2026-04-02T02:49:41Z

Pull the latest, make the change, add additional tests to verify, make sure all tests are passing and all files are correctly formatted.

Pulled latest from main, fixed the "void" matching to use TypeSpec's builtin void type via isVoidType, and added a test verifying void-void match. All 290 tests pass and files are formatted. Done in e8aef92.

pkg-pr-new · 2026-04-02T18:43:47Z

Open in StackBlitz

npm i https://pkg.pr.new/@azure-tools/typespec-azure-resource-manager@4145

npm i https://pkg.pr.new/@azure-tools/typespec-azure-rulesets@4145

commit: 1196313

markcowl · 2026-04-02T18:44:14Z

@copilot pull the latest and fix any merge issues

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-04-02T18:53:00Z

@copilot pull the latest and fix any merge issues

Pulled latest from main and merged cleanly in e5dbc09. The three-dot diff only contains PR-related files. All 290 tests pass and files are formatted.

markcowl

Pull the latest, make the suggested fixes and also add tests (or add to existing tests) to test these additional finalResult types for both template instantiations and raw operations.

Ensure that all tests pass, that there are no merge issues with main and that all files are correctly formatted.

packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

…or scalar and unknown types Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/097ee85d-b143-454b-baab-9431c663682b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/097ee85d-b143-454b-baab-9431c663682b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-04-02T22:16:23Z

Pull the latest, make the suggested fixes and also add tests (or add to existing tests) to test these additional finalResult types for both template instantiations and raw operations.

Ensure that all...

Pulled latest from main (merged cleanly), updated getResponseTemplateParam to handle Scalar and UnknownType in addition to Model, and added 4 new tests for these types. All 294 tests pass and files are formatted. Done in ebf307a and da8e547.

markcowl

Pull the latest from main, make the suggested changes and add any tests that are necessary to cover code changes, make sure all tests pass, all files are correctly formatted, and there are no merge issues with the main branch

packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts

packages/typespec-azure-resource-manager/test/rules/arm-post-lro-response-mismatch.test.ts

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

….each Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/aa99bc42-fed8-4568-b27b-ddb68950893a Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot · 2026-04-03T21:02:52Z

Pull the latest from main, make the suggested changes and add any tests that are necessary to cover code changes, make sure all tests pass, all files are correctly formatted, and there are no merge i...

Pulled latest from main (merged cleanly), fixed void type handling, refactored tests to use it.each, and added parameterized tests for all Response types (Model, unknown, scalar, void). All 296 tests pass, files formatted, no merge issues. Done in 1196313.

markcowl · 2026-04-03T21:22:09Z

/azp run typespec-azure - PR Tools

azure-pipelines · 2026-04-03T21:22:19Z

Azure Pipelines successfully started running 1 pipeline(s).

azure-sdk · 2026-04-03T21:23:36Z

All changed packages have been documented.

✅ @azure-tools/typespec-azure-resource-manager
✅ @azure-tools/typespec-azure-rulesets

Show changes

`@azure-tools/typespec-azure-resource-manager` - feature ✏️

Add linter rule arm-post-lro-response-mismatch to warn when a long-running POST operation's final result type does not match the 200 response body

`@azure-tools/typespec-azure-rulesets` - feature ✏️

Add linter rule arm-post-lro-response-mismatch to warn when a long-running POST operation's final result type does not match the 200 response body

azure-sdk · 2026-04-03T21:31:55Z

You can try these changes here

🛝 Playground	🌐 Website

Initial plan

4b6e875

Copilot AI assigned Copilot and markcowl Mar 28, 2026

Copilot started work on behalf of markcowl March 28, 2026 00:32 View session

Copilot AI linked an issue Mar 28, 2026 that may be closed by this pull request

[Linter] Add a linter to warn if the Response value doesn't match the FinalResult for ARM LRO POST #2524

Open

Add linter rule arm-post-lro-response-mismatch for ARM POST LRO opera…

28bebb7

…tions Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

microsoft-github-policy-service bot added the lib:azure-resource-manager Issues for @azure-tools/typespec-azure-core library label Mar 28, 2026

Add codefix to suggest setting FinalResult in LroHeaders for arm-post…

e77b24d

…-lro-response-mismatch Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/7bf3456e-7b67-406e-a438-d26cf5637117 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot AI changed the title ~~[WIP] Add a linter to check Response value matches FinalResult for ARM LRO POST~~ Add linter rule arm-post-lro-response-mismatch for ARM POST LRO operations Mar 28, 2026

Copilot finished work on behalf of markcowl March 28, 2026 00:57

Copilot AI requested a review from markcowl March 28, 2026 00:57

markcowl requested changes Mar 31, 2026

View reviewed changes

Copilot started work on behalf of markcowl March 31, 2026 18:22 View session

Copilot AI and others added 2 commits March 31, 2026 18:30

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

142de4b

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Address review: support ActionAsync, provider actions, fix test wording

a9c28e6

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/52cf9dab-ba01-4457-92cd-cd8badcefa7d Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot AI requested a review from markcowl March 31, 2026 18:58

Copilot finished work on behalf of markcowl March 31, 2026 18:58

Copilot started work on behalf of markcowl March 31, 2026 19:59 View session

Regenerate docs for typespec-azure-resource-manager

7e87831

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/f4c32a71-7b4b-4f80-ba9b-5ba00fbfab8b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

microsoft-github-policy-service bot added the meta:website TypeSpec.io updates label Mar 31, 2026

Copilot finished work on behalf of markcowl March 31, 2026 20:08

markcowl requested changes Mar 31, 2026

View reviewed changes

packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts Show resolved Hide resolved

Copilot started work on behalf of markcowl March 31, 2026 20:11 View session

Add fallback for non-template operations: check 200 response body vs …

fcb4809

…finalResult Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/1f249f2b-9ceb-48a6-ba20-2449bb561b02 Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot finished work on behalf of markcowl March 31, 2026 20:28

Copilot AI requested a review from markcowl March 31, 2026 20:28

Copilot finished work on behalf of markcowl April 2, 2026 02:51

Copilot AI requested a review from markcowl April 2, 2026 02:51

markcowl added the int:azure-specs Run integration tests against azure-rest-api-specs label Apr 2, 2026

Copilot started work on behalf of markcowl April 2, 2026 18:44 View session

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

e5dbc09

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot finished work on behalf of markcowl April 2, 2026 18:54

markcowl requested changes Apr 2, 2026

View reviewed changes

packages/typespec-azure-resource-manager/src/rules/arm-post-lro-response-mismatch.ts Outdated Show resolved Hide resolved

Copilot started work on behalf of markcowl April 2, 2026 21:43 View session

Copilot AI and others added 3 commits April 2, 2026 21:47

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

3785cc9

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Handle Scalar and UnknownType in response template param, add tests f…

ebf307a

…or scalar and unknown types Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/097ee85d-b143-454b-baab-9431c663682b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Remove redundant Scalar type cast and unused import

da8e547

Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/097ee85d-b143-454b-baab-9431c663682b Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot finished work on behalf of markcowl April 2, 2026 22:21

Copilot AI requested a review from markcowl April 2, 2026 22:21

markcowl requested changes Apr 3, 2026

View reviewed changes

Copilot started work on behalf of markcowl April 3, 2026 20:39 View session

Copilot AI and others added 2 commits April 3, 2026 20:42

Merge remote-tracking branch 'origin/main' into copilot/add-linter-fo…

e16023d

…r-arm-post-lro Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Allow void types in Response template param, refactor tests to use it…

1196313

….each Agent-Logs-Url: https://github.com/Azure/typespec-azure/sessions/aa99bc42-fed8-4568-b27b-ddb68950893a Co-authored-by: markcowl <1054056+markcowl@users.noreply.github.com>

Copilot finished work on behalf of markcowl April 3, 2026 21:04

Copilot AI requested a review from markcowl April 3, 2026 21:04

markcowl approved these changes Apr 3, 2026

View reviewed changes

Conversation

Copilot AI commented Mar 28, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

markcowl commented Mar 31, 2026

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Mar 31, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

Uh oh!

pkg-pr-new bot commented Apr 2, 2026 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

markcowl commented Apr 2, 2026

Uh oh!

Copilot AI commented Apr 2, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Copilot AI commented Apr 2, 2026

Uh oh!

markcowl left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Copilot AI commented Apr 3, 2026

Uh oh!

markcowl commented Apr 3, 2026

Uh oh!

azure-pipelines bot commented Apr 3, 2026

Uh oh!

azure-sdk commented Apr 3, 2026

@azure-tools/typespec-azure-resource-manager - feature ✏️

@azure-tools/typespec-azure-rulesets - feature ✏️

Uh oh!

azure-sdk commented Apr 3, 2026

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

3 participants

Copilot AI commented Mar 28, 2026 •

edited

Loading

pkg-pr-new bot commented Apr 2, 2026 •

edited

Loading

`@azure-tools/typespec-azure-resource-manager` - feature ✏️

`@azure-tools/typespec-azure-rulesets` - feature ✏️