Skip to content

Feat/visual regression testing - #345

Closed
mubking wants to merge 6 commits into
BETAIL-BOYS:mainfrom
mubking:feat/visual-regression-testing
Closed

Feat/visual regression testing#345
mubking wants to merge 6 commits into
BETAIL-BOYS:mainfrom
mubking:feat/visual-regression-testing

Conversation

@mubking

@mubking mubking commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

Closes #252

Description

Closes #[ISSUE_NUMBER]

Type of Change

  • Bug fix (non-breaking change that fixes an issue)
  • New feature (non-breaking change that adds functionality)
  • Breaking change (fix or feature that would break existing functionality)
  • Refactor (code improvement without functional changes)
  • Documentation update

Testing Strategy

  • I have run the linter and type checker
  • I have added/updated tests
  • All existing tests pass

Self-Review Checklist

  • My code follows the project's coding style
  • I have reviewed my own code for potential issues
  • I have added necessary documentation/comments
  • I have updated relevant README or docs if needed
  • No new warnings or errors are introduced
  • Changes are backward-compatible (or documented breaking changes)

@AlAfiz

AlAfiz commented Jun 23, 2026

Copy link
Copy Markdown
Contributor

@mubking you're going to have to close this PR and start fresh.

Looking at the diff, there's way too much going on here almost 12,000 lines changed and a ton of auto-generated Storybook tutorial junk (like those figma and docs images). The issue description specifically asked to keep the setup lightweight.

Can you close this out, delete all those boilerplate assets, and open a clean PR with just the Chromatic/Storybook setup for the core UI components? Let's keep the branch strictly scoped to what's in the ticket.

@mubking mubking closed this Jun 23, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Implement visual regression testing (e.g., Chromatic) for core UI components

3 participants