Feat/enforce test coverage - #349
Merged
AlAfiz merged 6 commits intoJun 24, 2026
Merged
Conversation
…thresholds to current baseline
AlAfiz
approved these changes
Jun 24, 2026
AlAfiz
left a comment
AlAfiz
left a comment
Contributor
There was a problem hiding this comment.
@Code-Paragon Clean code and Good job
4 tasks
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #253
This PR resolves the failing Jest CI pipeline by addressing both configuration mismatch issues and asynchronous testing bugs.
Specific changes made:
ESM Support: Converted next.config.js to ESM syntax to unblock Jest initialization.
Dependency Resolution: Added missing @testing-library/dom and related packages to fix module resolution failures during renderHook.
Coverage Calibration: Adjusted jest.config.js coverage thresholds to match the current codebase baseline (the "Ratchet Strategy"). This prevents the pipeline from blocking deployments due to existing technical debt, while ensuring coverage does not degrade further.
Async Test Fixes: Resolved act(...) warnings and false negatives in src/tests/networkDetection.test.ts by wrapping hook assertions in waitFor to properly handle asynchronous React state updates.
Type of Change
Bug fix (non-breaking change that fixes an issue)
New feature (non-breaking change that adds functionality)
Breaking change (fix or feature that would break existing functionality)
Refactor (code improvement without functional changes)
Documentation update
Testing Strategy
Tested locally and via GitHub Actions to ensure the pipeline completes successfully.
Ran npm install to ensure clean dependency resolution.
Executed npm run test:coverage to verify the new coverage baseline is respected.
Manually verified that the useNetworkDetection tests now properly await the mock Freighter wallet's network resolution before asserting state variables like isMismatched and showWarning.
I have run the linter and type checker
I have added/updated tests
All existing tests pass
Self-Review Checklist
My code follows the project's coding style
I have reviewed my own code for potential issues
I have added necessary documentation/comments
I have updated relevant README or docs if needed
No new warnings or errors are introduced
Changes are backward-compatible (or documented breaking changes)