Fix uninitialized memory reads found by valgrind#145
Merged
vfonov merged 1 commit intoBIC-MNI:developfrom Mar 31, 2026
Merged
Conversation
Initialize derv_usr_float and derv_var_float in miicv_create() so miicv_ndattach() does not read garbage when the user_do_range path skips MI_icv_get_norm(). Zero-initialize the stack-allocated VIO_multidim_array in multidim_test so multidim_array_is_alloced() does not branch on an indeterminate n_dimensions. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
derv_usr_floatandderv_var_floatinmiicv_create()somiicv_ndattach()does not read uninitialized heap memory when theuser_do_rangepath skipsMI_icv_get_norm()VIO_multidim_arrayinmultidim_testsomultidim_array_is_alloced()does not branch on an indeterminaten_dimensionsTest plan
valgrind --leak-check=full --track-origins=yeswith 0 errors and 0 definite/possible leaksminc2-leak-test(100K iterations, 5.6M allocs, 0 leaks under valgrind)🤖 Generated with Claude Code Opus 4.6 with maximum effort
Prompt
Compile and run the tests under valgrind. Enable NIFTI support. Make the minimal changes to address any bugs.