[mod_logfile] Add structured channel log tags - #1
Draft
BIT-ja wants to merge 2 commits into
Draft
Conversation
Changes: - Use single-evaluation assertions for event creation, channel tag access, and prefix configuration helpers. - Remove the ineffective event-reclaim teardown workaround. Bug Analysis: - Symptom: ASAN reported leaked events allocated by switch_event_create_plain() and switch_channel_get_log_tags(). - Root cause: fst_check_int_equals evaluates its first argument twice, so side-effecting calls allocated or duplicated an event twice and overwrote the first pointer. - Evidence: every leak stack points to a side-effecting call passed as the first argument; the teardown workaround left the leak count and stacks unchanged. - Fix: use fst_check(call() == expected), which evaluates the call once. - Risk: test-only assertion changes; production behavior is unchanged. Checkout Source: upstream/master Verification: - git diff --check passed. - GitHub ASAN CI reproduced the RED state and confirmed the teardown workaround was ineffective. - Green GitHub CI pending after push. Committer: Codex (GPT-5)
BIT-ja
force-pushed
the
feature/mod-logfile-structured-tags
branch
from
July 14, 2026 11:33
e5a6039 to
7455171
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
Adds structured per-channel context to
mod_logfileoutput and aset_log_tagdialplan application.set_log_tag name=valuesets or replaces a channel log tag.set_log_tag name=andset_log_tag nameremove it.mod_logfilecan include captured tags and configured live channel variables in the prefix of each physical log line.The implementation also handles APR short writes, partial-error writes, transient reopen failures, HUP/rotation cleanup, allocation failures with raw fallback, and UTF-8-safe value sanitation.
Existing UUID behavior remains enabled by default.
log-tagsandchannel-varsare opt-in.Type of Change
Related Issues
Upstream PR: signalwire#3077
Testing
This PR is used to run the fork's GitHub Actions workflows against the exact upstream PR commit.
Checklist
Additional Notes
CI preflight for signalwire#3077. The head commit is
1df022dfa5e14f12fe97740ba84d6d5a55f6186b.