Client: when computing disk usage, don't include VM shared directories - #3901
Draft
davidpanderson wants to merge 1 commit into
Draft
Client: when computing disk usage, don't include VM shared directories#3901davidpanderson wants to merge 1 commit into
davidpanderson wants to merge 1 commit into
Conversation
These directories are inside the VM, so we've already counted them. Also, traversing them can be very slow if the dir is big (e.g. nanoHUB@home)
Contributor
Author
|
The Travis CI build is failing on fetching sqlite. |
Member
|
@davidpanderson, I see sqlite3 usage still in browser.cpp |
Member
|
I found this branch: https://github.com/BOINC/boinc/compare/dpa_remove_sqlite |
Contributor
Author
|
I must have forgotten to make a PR for that.
…On Mon, Jul 13, 2020 at 5:23 PM Vitalii Koshura ***@***.***> wrote:
I found this branch:
https://github.com/BOINC/boinc/compare/dpa_remove_sqlite
—
You are receiving this because you were mentioned.
Reply to this email directly, view it on GitHub
<#3901 (comment)>, or
unsubscribe
<https://github.com/notifications/unsubscribe-auth/AAHQVAKQQ5K2NLJ37JC7DA3R3OQQTANCNFSM4OXGRNNA>
.
|
Contributor
Author
|
That file (browser.cpp) should be removed. |
Member
|
@davidpanderson, it's already removed in a different PR |
Contributor
Author
|
Actually, it turns out that shared/ resides in the host FS, |
Member
|
I'm changing this PR to draft then. Feel free to change it back when you think it's ready |
AenBleidd
marked this pull request as draft
July 16, 2020 00:08
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
These directories are inside the VM, so we've already counted them.
Also, traversing them can be very slow if the dir is big (e.g. nanoHUB@home)