Add support for Cognito - #262
Conversation
| @@ -10,12 +10,13 @@ import spray.json._ | |||
|
|
|||
| case class `AWS::AutoScaling::AutoScalingGroup`( | |||
There was a problem hiding this comment.
Looks like you shouldn't be specifying both AvailabilityZones and VPCZoneIdentifier. For maximum type safety we should make both optional and make the whole constructor private. Then we can add 2 new methods that instantiate a ASG with the different methods as well as a default for backwards compatibility in the companion. See AWS::EC2::EIP as an example.
| @@ -0,0 +1,243 @@ | |||
| package com.monsanto.arch.cloudformation.codegen | |||
There was a problem hiding this comment.
This seems like a really cool idea. Can you add some sort guide on how to use it to the README under a how to add new types section?
|
@chrisshafer I'm finally getting around to catching up on PRs here. Is this still something we'd like to see merged? I see @tj-corrigan had a couple comments. |
|
@bkrodgers likely, I'll see if I can find the time in the next couple weeks. |
3 participants
AWS::AutoScaling::AutoScalingGroupto support conditional AZ's and health checks.AWS::ECS::ServiceFixes: #165