Join Page#85
Merged
Crossedfall merged 3 commits intoBeeStation:masterfrom Jun 29, 2025
Merged
Conversation
There was a problem hiding this comment.
Pull Request Overview
Adds a dedicated join page that explains how to connect via BYOND if the protocol handler fails, and handles nonexistent join IDs gracefully with a 404 instead of a 500.
- Introduces a minimal layout template for standalone pages
- Creates
join.htmlwith redirect script, fallback instructions, and copy-to-clipboard button - Updates
page_joincontroller to render the new template and return 404 when the server ID is invalid
Reviewed Changes
Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.
| File | Description |
|---|---|
| src/beesite/templates/layout_minimal.html | New minimal base layout with open graph tags and blocks |
| src/beesite/templates/join.html | New join page template with redirect, instructions, CSS |
| src/beesite/modules/redirects/controllers.py | Updated join route to render template and handle missing IDs |
Comments suppressed due to low confidence (1)
src/beesite/modules/redirects/controllers.py:15
- The
abortfunction is used here but not imported; please addfrom flask import abortto avoid a NameError.
return abort(404)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Changes the join redirects to render a template page explaining how to connect if BYOND is down and providing the direct link.
Also fixes 500 Internal Server Error when requesting nonexistent join ids.
Copy SVG is under a free license from https://uxwing.com/copy-icon/ https://uxwing.com/license/