Skip to content

Join Page#85

Merged
Crossedfall merged 3 commits intoBeeStation:masterfrom
itsmeowForks:join-page
Jun 29, 2025
Merged

Join Page#85
Crossedfall merged 3 commits intoBeeStation:masterfrom
itsmeowForks:join-page

Conversation

@itsmeow
Copy link
Copy Markdown
Member

@itsmeow itsmeow commented Jun 29, 2025

Changes the join redirects to render a template page explaining how to connect if BYOND is down and providing the direct link.

Also fixes 500 Internal Server Error when requesting nonexistent join ids.

Copy SVG is under a free license from https://uxwing.com/copy-icon/ https://uxwing.com/license/

image

@Crossedfall Crossedfall requested a review from Copilot June 29, 2025 16:02
Copy link
Copy Markdown

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull Request Overview

Adds a dedicated join page that explains how to connect via BYOND if the protocol handler fails, and handles nonexistent join IDs gracefully with a 404 instead of a 500.

  • Introduces a minimal layout template for standalone pages
  • Creates join.html with redirect script, fallback instructions, and copy-to-clipboard button
  • Updates page_join controller to render the new template and return 404 when the server ID is invalid

Reviewed Changes

Copilot reviewed 3 out of 3 changed files in this pull request and generated 2 comments.

File Description
src/beesite/templates/layout_minimal.html New minimal base layout with open graph tags and blocks
src/beesite/templates/join.html New join page template with redirect, instructions, CSS
src/beesite/modules/redirects/controllers.py Updated join route to render template and handle missing IDs
Comments suppressed due to low confidence (1)

src/beesite/modules/redirects/controllers.py:15

  • The abort function is used here but not imported; please add from flask import abort to avoid a NameError.
        return abort(404)

Comment thread src/beesite/templates/join.html
Comment thread src/beesite/templates/layout_minimal.html Outdated
@Crossedfall Crossedfall merged commit 0f39079 into BeeStation:master Jun 29, 2025
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants