Skip to content

wallet: restrict sensitive RPC commands under --restricted-rpc #212

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
sanada08 merged 5 commits into from
Aug 12, 2026
Merged

wallet: restrict sensitive RPC commands under --restricted-rpc #212

Show file tree
Hide file tree
Changes from 3 commits
Commits
Show all changes
5 commits
Select commit Hold shift + click to select a range
7f02243
wallet: restrict sensitive RPC commands under --restricted-rpc
deen-kakarot Aug 6, 2026
0a496df
wallet: restrict start_mining and stop_mining RPC commands
deen-kakarot Aug 7, 2026
8ae179b
build: increase _FORTIFY_SOURCE protection level and update README
deen-kakarot Aug 7, 2026
75f12f5
update: wallet RPC version and libcurl dependency documentation
deen-kakarot Aug 11, 2026
580ad8a
add: bounds check for P2P block and transaction requests
deen-kakarot Aug 11, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions CMakeLists.txt
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -571,8 +571,8 @@ else()

# if those don't work for your compiler, single it out where appropriate
if(CMAKE_BUILD_TYPE STREQUAL "Release" AND NOT OPENBSD)
set(C_SECURITY_FLAGS "${C_SECURITY_FLAGS} -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1")
set(CXX_SECURITY_FLAGS "${CXX_SECURITY_FLAGS} -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=1")
set(C_SECURITY_FLAGS "${C_SECURITY_FLAGS} -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2")
set(CXX_SECURITY_FLAGS "${CXX_SECURITY_FLAGS} -U_FORTIFY_SOURCE -D_FORTIFY_SOURCE=2")
endif()

# warnings
Expand Down
2 changes: 1 addition & 1 deletion README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,7 @@ breakdown of the minimum set of required boost packages.
Install all dependencies at once on Debian/Ubuntu:

```
sudo apt update && sudo apt install build-essential cmake pkg-config libboost-all-dev libzmq3-dev libsodium-dev libunwind8-dev liblzma-dev libreadline6-dev doxygen graphviz libpgm-dev libsqlite3-dev curl
sudo apt update && sudo apt install build-essential cmake pkg-config libboost-all-dev libzmq3-dev libsodium-dev libunwind8-dev liblzma-dev libreadline6-dev doxygen graphviz libpgm-dev libsqlite3-dev curl libcurl4-openssl-dev
Comment thread
coderabbitai[bot] marked this conversation as resolved.
```

Install all dependencies at once on macOS with the provided Brewfile:
Expand Down
10 changes: 5 additions & 5 deletions src/wallet/wallet_rpc_server_commands_defs.h
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1365,7 +1365,7 @@ BELDEX_RPC_DOC_INTROSPECT

BELDEX_RPC_DOC_INTROSPECT
// Export transfers to csv
struct EXPORT_TRANSFERS : RPC_COMMAND
struct EXPORT_TRANSFERS : RESTRICTED
Comment thread
coderabbitai[bot] marked this conversation as resolved.
{
static constexpr auto names() { return NAMES("export_transfers"); }

Expand Down Expand Up @@ -1419,7 +1419,7 @@ BELDEX_RPC_DOC_INTROSPECT

BELDEX_RPC_DOC_INTROSPECT
// Export a signed set of key images.
struct EXPORT_KEY_IMAGES : RPC_COMMAND
struct EXPORT_KEY_IMAGES : RESTRICTED
{
static constexpr auto names() { return NAMES("export_key_images"); }

Expand Down Expand Up @@ -1668,7 +1668,7 @@ BELDEX_RPC_DOC_INTROSPECT

BELDEX_RPC_DOC_INTROSPECT
// Start mining in the beldex daemon.
struct START_MINING : RPC_COMMAND
struct START_MINING : RESTRICTED
Comment thread
coderabbitai[bot] marked this conversation as resolved.
{
static constexpr auto names() { return NAMES("start_mining"); }

Expand All @@ -1684,7 +1684,7 @@ BELDEX_RPC_DOC_INTROSPECT

BELDEX_RPC_DOC_INTROSPECT
// Stop mining in the beldex daemon.
struct STOP_MINING : RPC_COMMAND
struct STOP_MINING : RESTRICTED
{
static constexpr auto names() { return NAMES("stop_mining"); }

Expand Down Expand Up @@ -1753,7 +1753,7 @@ BELDEX_RPC_DOC_INTROSPECT

BELDEX_RPC_DOC_INTROSPECT
// Close the currently opened wallet, after trying to save it.
struct CLOSE_WALLET : RPC_COMMAND
struct CLOSE_WALLET : RESTRICTED
{
static constexpr auto names() { return NAMES("close_wallet"); }

Expand Down
Loading