Skip to content

AP-495: move to Github Actions#1

Merged
anarchivist merged 5 commits intomainfrom
AP-495-gha
Nov 20, 2025
Merged

AP-495: move to Github Actions#1
anarchivist merged 5 commits intomainfrom
AP-495-gha

Conversation

@anarchivist
Copy link
Copy Markdown
Member

@anarchivist anarchivist commented Nov 20, 2025 •
edited
Loading

  • Add new Github Actions workflows
  • Remove default .env file because we shouldn't commit secrets
  • Add compose configuration for CI

TODO:

  • Discuss arm64 build and upgrading (Wowza 4.8.25 doesn't ship an arm64 image; 4.9.6 does, but then we need to test upgrade)
  • Confirm secret filtering is working as expected

@anarchivist anarchivist force-pushed the AP-495-gha branch 8 times, most recently from f4f3bfc to 2c6f762 Compare November 20, 2025 04:25
@anarchivist
AP-495: move to Github Actions
a597754 
* Add new Github Actions workflows
* Remove default .env file because we shouldn't commit secrets
* Add compose configuration for CI
@anarchivist
avoid building arm for now, only because wowza at this version doesn'…
c22a7b8 
…t have an arm image
@anarchivist anarchivist self-assigned this Nov 20, 2025
danschmidt5189
danschmidt5189 approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@danschmidt5189 danschmidt5189 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me! I'm in favor of following up with the Wowza upgrade / arm64 support in a subsequent PR. I don't think that'll be especially difficult or a breaking change, but it keeps this diff clean/focused.

awilfox
awilfox requested changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@awilfox awilfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good but needs the README updated since we are changing how .env works.

Comment thread docker-compose.ci.yml Outdated
Comment thread .gitignore
awilfox
awilfox approved these changes Nov 20, 2025
View reviewed changes
Copy link
Copy Markdown
Member

@awilfox awilfox left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Small nit re GitHub capitalisation. Otherwise looks great. r+

(also the .env file doesn't look removed any more in the Files Changed view? it is still removed in the commits, so I think it's just a bug with GitHub's Web view.)

Comment thread README.md Outdated
@awilfox
Copy link
Copy Markdown
Member

awilfox commented Nov 20, 2025

Small question: why was LICENSE removed?

@anarchivist
Copy link
Copy Markdown
Member Author

anarchivist commented Nov 20, 2025

Small question: why was LICENSE removed?

because i didn't realize there was already a LICENSE.md file.

@anarchivist @awilfox
Update README.md
a3c25a6 
Co-authored-by: Anna Wilcox <AWilcox@Wilcox-Tech.com>
@awilfox
Copy link
Copy Markdown
Member

awilfox commented Nov 20, 2025

Small question: why was LICENSE removed?

because i didn't realize there was already a LICENSE.md file.

Ah, right, I didn't see that either. Also, as an aside from the parenthetical on my review comment: the GitHub Web view has decided .env was renamed to env.example instead of removed and replaced with a new file. It's still gone out of the repo in the MR. This is good.

@anarchivist anarchivist merged commit 1ac9bff into main Nov 20, 2025
4 checks passed
@anarchivist anarchivist deleted the AP-495-gha branch November 20, 2025 20:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@awilfox awilfox awilfox approved these changes

@danschmidt5189 danschmidt5189 danschmidt5189 approved these changes

Assignees

@anarchivist anarchivist

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

3 participants

@anarchivist @awilfox @danschmidt5189