Add accessible toggle component and update layouts - #139
Merged
therealjhay merged 3 commits intoJun 27, 2026
Conversation
|
@cladiousdoff-glitch is attempting to deploy a commit to the therealjhay's projects Team on Vercel. A member of the Team first needs to authorize it. |
|
@cladiousdoff-glitch Great news! 🎉 Based on an automated assessment of this PR, the linked Wave issue(s) no longer count against your application limits. You can now already apply to more issues while waiting for a review of this PR. Keep up the great work! 🚀 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Closes #3
Closes #4
Closes #5
Closes #6
Implemented the remaining accessibility fix.
Added a reusable semantic switch at components/ui/toggle.tsx (line 10) with:
role="switch"
aria-checked={checked}
visible On / Off text
native button click, Space, and Enter activation
Updated the Settings notification preferences in [app/(merchant)/settings/page.tsx (line 22)](C:/Users/Marvel/BettaPay-Frontend/app/(merchant)/settings/page.tsx:22) to use boolean state and the new switch component.
I also verified the other requested a11y pieces are already present:
Skip link in app/layout.tsx (line 25)
id="main-content" and tabIndex={-1} in both merchant/admin layouts
No global :focus { outline: none !important; }; only the existing :focus-visible rule remains in app/globals.css (line 77)
Verification notes: npm.cmd run lint and npx.cmd tsc --noEmit both run, but fail on pre-existing unrelated issues in dashboard/auth tests and other pages. No reported errors point to the files changed here.