Add support for snitch's defmethod#36
Merged
Merged
Conversation
Contributor
|
Thanks! 🙏 |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description
This MR adds support for the defmethod* macro in all existing snitch commands, namely:
{ "command": "cpt.snitch.instrumentTopLevelForm", "category": "[CPT] Snitch", "title": "Instrument Top Level defn/defmethod/let/fn" }, { "command": "cpt.snitch.instrumentCurrentForm", "category": "[CPT] Snitch", "title": "Instrument Current Form defn/defmethod/let/fn" }, { "command": "cpt.snitch.getSnitchedDefnResults", "category": "[CPT] Snitch", "title": "Get Snitched defn/defmethod Results" }, { "command": "cpt.snitch.reconstructLastDefnCallToClipboard", "category": "[CPT] Snitch", "title": "Reconstruct Last defn/defmethod Call to Clipboard" },Closes #31
Since there is no tests for this, I am attaching a video for both clj/cljs
defmethod_clj.mov
defmethod_cljs.mov
Checklist
[Unreleased]section of CHANGELOG.md linking to the issue(s) addressed