Skip to content

test(grz-cli): cover upload workflow with symlinks (closes #538)#551

Merged
Hoeze merged 5 commits into
BfArM-MVH:mainfrom
jblesch:test/symlink-support
May 4, 2026
Merged

test(grz-cli): cover upload workflow with symlinks (closes #538)#551
Hoeze merged 5 commits into
BfArM-MVH:mainfrom
jblesch:test/symlink-support

Conversation

@jblesch

@jblesch jblesch commented Apr 27, 2026

Copy link
Copy Markdown
Collaborator

This PR adds test coverage for LE submissions that contain symlinks inside submission/files/.

What changed

  • Test file: Updated test_upload.py — replaced the old symlink test with test_upload_workflow_succeeds_with_symlinks_to_real_test_files.
  • Removed: @pytest.mark.parametrize for grz_check_flag and the associated skip logic.
  • Behavior: The test now creates symlinks in the working submission files/ directory that point directly at fixture files under files. Metadata is still copied.

Why

  • Symlinks can occur in real submission folders; this ensures the validate/encrypt/upload workflow doesn’t break when files/ entries are symlinked.

Closes #538

@jblesch jblesch requested review from Hoeze and tedil April 27, 2026 15:31

@Hoeze Hoeze left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

That did not quite work out 😄

  • The grz-check flag change is unrelated and will be removed anyways
  • There is no other files changed
  • We rather want a separate test that creates symlinks to the real test files within the tests

@jblesch jblesch requested a review from Hoeze May 4, 2026 08:46
@jblesch jblesch changed the title test(cli): cover upload workflow with symlinks (closes #538) test(grz-cli): cover upload workflow with symlinks (closes #538) May 4, 2026
@jblesch

jblesch commented May 4, 2026

Copy link
Copy Markdown
Collaborator Author

That did not quite work out 😄

  • The grz-check flag change is unrelated and will be removed anyways
  • There is no other files changed
  • We rather want a separate test that creates symlinks to the real test files within the tests

adapted accordingly; pls check again

@Hoeze Hoeze left a comment

Copy link
Copy Markdown
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good!

@Hoeze Hoeze added this pull request to the merge queue May 4, 2026
Merged via the queue into BfArM-MVH:main with commit 56a513a May 4, 2026
9 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Re-consider symlink support

2 participants