Skip to content

feat(grz-common): Log hostname#599

Merged
Hoeze merged 2 commits into
mainfrom
copilot/feat-log-hostname-where-tools-run
Jun 20, 2026
Merged

feat(grz-common): Log hostname#599
Hoeze merged 2 commits into
mainfrom
copilot/feat-log-hostname-where-tools-run

Conversation

Copilot AI commented Jun 10, 2026 •
edited by Hoeze
Loading

Copy link
Copy Markdown
Contributor

No description provided.

Copilot AI linked an issue Jun 10, 2026 that may be closed by this pull request
feat: log hostname where tools run #567
Closed
@Hoeze

Hoeze commented Jun 10, 2026

Copy link
Copy Markdown
Collaborator

@copilot would it make more sense to directly format LOGGING_FORMAT with the correct hostname, given that this should be static within runs?

Copilot AI changed the title [WIP] Update logger configuration to log hostname feat(grz-common): log hostname in shared tool logging Jun 10, 2026
Copilot AI requested a review from Hoeze June 10, 2026 18:57
Copilot finished work on behalf of Hoeze June 10, 2026 18:57

Copilot AI commented Jun 10, 2026

Copy link
Copy Markdown
Contributor Author

@copilot would it make more sense to directly format LOGGING_FORMAT with the correct hostname, given that this should be static within runs?

Yes — I switched to that approach in 9913ad7. LOGGING_FORMAT now embeds the static HOSTNAME directly, and the LogRecordFactory wrapper was removed.

Copilot AI changed the title feat(grz-common): log hostname in shared tool logging feat(grz-common): log static hostname in shared tool logging Jun 10, 2026
Copilot finished work on behalf of Hoeze June 10, 2026 19:01
tedil
tedil reviewed Jun 11, 2026
View reviewed changes
Comment thread packages/grz-common/src/grz_common/logging.py Outdated
Copilot AI changed the title feat(grz-common): log static hostname in shared tool logging fix(grz-common): set HOSTNAME to None on failure, omit from log format Jun 11, 2026
Copilot finished work on behalf of Hoeze June 11, 2026 19:47
Copilot finished work on behalf of Hoeze June 11, 2026 19:50
Hoeze
Hoeze reviewed Jun 11, 2026
View reviewed changes
Comment thread packages/grz-common/tests/test_logging.py Outdated
Copilot finished work on behalf of Hoeze June 11, 2026 20:00
Copilot AI requested a review from Hoeze June 11, 2026 20:00
@Hoeze Hoeze marked this pull request as ready for review June 11, 2026 20:03
@Hoeze Hoeze force-pushed the copilot/feat-log-hostname-where-tools-run branch from 5035a7f to 8a88f0a Compare June 11, 2026 20:08
@Hoeze Hoeze changed the title fix(grz-common): set HOSTNAME to None on failure, omit from log format feat(grz-common): Log hostname Jun 11, 2026
@Hoeze
refactor(grz-common): extract hostname/format helpers for testability
5efa79c 
Move import-time hostname resolution and format construction into
get_hostname() and build_logging_format() so tests exercise them
directly instead of reloading the module.
@Hoeze

Hoeze commented Jun 11, 2026

Copy link
Copy Markdown
Collaborator

copilot was not so helpful 😄 but well

@Hoeze Hoeze requested a review from tedil June 11, 2026 20:15
@Hoeze Hoeze added this pull request to the merge queue Jun 20, 2026
Merged via the queue into main with commit 9e5b74e Jun 20, 2026
13 checks passed
@Hoeze Hoeze deleted the copilot/feat-log-hostname-where-tools-run branch June 20, 2026 23:50
@MVHBot MVHBot mentioned this pull request Jun 20, 2026
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@tedil tedil tedil approved these changes
@Hoeze Hoeze Awaiting requested review from Hoeze

Assignees

@Hoeze Hoeze

Copilot code review Copilot

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

feat: log hostname where tools run

3 participants

@Hoeze @tedil