feat(grz-db): fixes the failing signature status issue(#597)#625
Closed
virag-compbio wants to merge 5 commits into
Closed
feat(grz-db): fixes the failing signature status issue(#597)#625virag-compbio wants to merge 5 commits into
virag-compbio wants to merge 5 commits into
Conversation
virag-compbio
changed the title
Collaborator
Author
|
Closing this PR and restarting a new one for this issue that is based off the main. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix:
Changed serialize_datetime_to_iso_z in packages/grz-db/src/grz_db/common.py to return dt.isoformat().replace("+00:00", "Z").
This restores the Z format, matching what Pydantic v2 used to produce, so old signatures verify correctly again and new signatures stay consistent.