fix(grz-db): datetime handling in signature evaluation#626
Open
virag-compbio wants to merge 2 commits into
Open
fix(grz-db): datetime handling in signature evaluation#626virag-compbio wants to merge 2 commits into
virag-compbio wants to merge 2 commits into
Conversation
tedil
changed the title
Collaborator
|
Does this fix the actual problem? At the moment, this only touches the serialization behaviour, so we may end up with a similar problem after this change, just the other way around? |
added 2 commits
July 8, 2026 14:13
…h older grzctl versions
Hoeze
force-pushed
the
fix/failing-signature-status
branch
from
1c363b3 to
3353fa2
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Resolves #597
Fix:
Changed serialize_datetime_to_iso_z in packages/grz-db/src/grz_db/common.py to return dt.isoformat().replace("+00:00", "Z").
This restores the Z format, matching what Pydantic v2 used to produce, so old signatures verify correctly again and new signatures stay consistent.