fix(grz-pydantic-models): handle datetime, FHIR extensions and verification in consent model (#610)Fix/consent field dtypes#627
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #610. The original bug there (non-zero time in dateTime) was already fixed, but the issue also asked whether other fields were handled correctly. Two things came out of it:
FHIR extensions. Real consent resources from LEs can carry id and extension on pretty much any element, but our Coding, CodeableConcept, and Period models used extra="forbid", so they'd reject an otherwise-valid resource just because it had an extension on a coding. Added a small FHIRElement base (optional id + extension) and had those three inherit from it. Unknown fields are still rejected.
Verification. The verification element (and its verificationDate) wasn't modeled at all. Added a Verification model and an optional verification list on Consent.