-
Notifications
You must be signed in to change notification settings - Fork 67
porting to debian_based_platforms #423
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: master
Are you sure you want to change the base?
Changes from all commits
3a6c6b3
d53fe4d
a4c9297
3428b0c
cbdea7e
b4ad6ec
a1be7fe
240d1ed
9239140
0aa343b
0a2bac5
d631512
a5f977f
c2802ae
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change |
|---|---|---|
|
|
@@ -17,6 +17,7 @@ | |
|
|
||
| #include <memory> | ||
| #include <string> | ||
| #include <cstdint> | ||
|
|
||
| namespace bdm { | ||
|
|
||
|
|
||
| Original file line number | Diff line number | Diff line change |
|---|---|---|
| @@ -1,3 +1,6 @@ | ||
| g++-11 | ||
| gcc-11 | ||
| gfortran-11 | ||
| clang | ||
| clang-format | ||
| clang-tidy | ||
|
|
||
|
Contributor
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Thanks for the updates! From what I can see, several packages promoted to “required” don’t seem necessary for a minimal build. Could we move them back to package_list_extra unless the core build fails without them? If any of these are hard requirements for the default configuration, please keep them and add a short rationale inline so it’s clear why they’re in the required set.
Collaborator
Author
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Dear stavros @sportokalidis . From the packages I inspected I think that the lsb_release and gcc-11 are the only optional ones. Other packages like patch may come preinstalled in some distros. So I will rebase the commit and make the required change. I am really sorry for the delay, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
remove leading spaces before elif for consistency with surrounding indentation.