Skip FTCS solver for zero-diffusion grids#459
Open
stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
Open
Skip FTCS solver for zero-diffusion grids#459stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
stanbot8 wants to merge 1 commit intoBioDynaMo:masterfrom
Conversation
2 tasks
Contributor
|
Hi @stanbot8, Thanks for the contribution! I’ll review the changes and get back to you. In the meantime: the CI issue that previously prevented Could you please update your PR branch with the latest |
stanbot8
force-pushed
the
opt/skip-ftcs-zero-diffusion
branch
from
da8828e to
e34c6fe
Compare
When the diffusion coefficient is 0 but decay is nonzero, apply decay as a simple element-wise multiply instead of running the full FTCS stencil. The Laplacian term vanishes with D=0, so the stencil computation is wasted work.
stanbot8
force-pushed
the
opt/skip-ftcs-zero-diffusion
branch
from
e34c6fe to
f7b1bbf
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
EulerGrid::DiffuseWith*now applies decay as a simple element-wise multiply instead of running the full FTCS stencil. The Laplacian term vanishes with D=0, so the stencil computation is wasted work.}) indiffusion_grid.h.Test plan
EulerDepletionConvergenceExponentialDecayandDepletionMissmatch(both use D=0 depletion grids)