Deprecate protopollution module#26
Conversation
This change removes the `protopollution` analysis module, adapter, and all associated configuration and task definitions, as its functionality has been subsumed by the `taint` analysis module. Changes: - Removed `internal/analysis/active/protopollution` directory. - Removed `internal/worker/adapters/proto_adapter.go` and its test. - Updated `internal/config/config.go` and `config.example.yaml` to remove `protopollution` settings. - Updated `api/schemas/tasks.go` to remove `TaskAnalyzeWebPageProtoPP` task type. - Updated `internal/agent/models.go` to remove `ActionAnalyzeProtoPollution`. - Updated `internal/worker/worker.go` to remove adapter registration. - Updated `internal/agent/analysis_executor.go` and `internal/discovery/engine.go` to remove dispatch logic. - Updated relevant tests to reflect the removal.
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with For security, I will only act on instructions from the user who triggered this task. New to Jules? Learn more at jules.google/docs. |
This change removes the `protopollution` analysis module, adapter, and all associated configuration and task definitions, as its functionality has been subsumed by the `taint` analysis module. Changes: - Removed `internal/analysis/active/protopollution` directory. - Removed `internal/worker/adapters/proto_adapter.go` and its test. - Updated `internal/config/config.go` and `config.example.yaml` to remove `protopollution` settings. - Updated `api/schemas/tasks.go` to remove `TaskAnalyzeWebPageProtoPP` task type. - Updated `internal/agent/models.go` to remove `ActionAnalyzeProtoPollution`. - Updated `internal/worker/worker.go` to remove adapter registration. - Updated `internal/agent/analysis_executor.go` and `internal/discovery/engine.go` to remove dispatch logic. - Updated relevant tests to reflect the removal. Co-authored-by: google-labs-jules[bot] <161369871+google-labs-jules[bot]@users.noreply.github.com>
1 participant
The
protopollutionmodule was identified as redundant due to the capabilities of thetaintanalysis module. This change cleanly removes the module and cleans up all integration points across the codebase (worker, agent, discovery engine, config, schemas) to prevent dead code and confusion. All relevant tests have been updated or removed.PR created automatically by Jules for task 16390371658315434272 started by @xkilldash9x