chore: solidify len/cap impurity check for maps/chans and add tests#15
Conversation
- Verify and solidify the impurity check for `len()` and `cap()` on maps and channels in `canonicalizer.go`. - Replace "FIX" marker with "Note" to reflect that the logic is implemented and intentional. - Add regression test `TestCanonicalizer_HoistSafety_Chan` in `ir_test.go` to ensure `len(chan)` and `cap(chan)` are not hoisted out of loops. Co-authored-by: xkilldash9x <223238109+xkilldash9x@users.noreply.github.com>
|
👋 Jules, reporting for duty! I'm here to lend a hand with this pull request. When you start a review, I'll add a 👀 emoji to each comment to let you know I've read it. I'll focus on feedback directed at me and will do my best to stay out of conversations between you and other bots or reviewers to keep the noise down. I'll push a commit with your requested changes shortly after. Please note there might be a delay between these steps, but rest assured I'm on the job! For more direct control, you can switch me to Reactive Mode. When this mode is on, I will only act on comments where you specifically mention me with New to Jules? Learn more at jules.google/docs. For security, I will only act on instructions from the user who triggered this task. |
xkilldash9x
deleted the
chore/fix-len-cap-impurity-marker-and-test-8490562561725051731
branch
1 participant
This change addresses a "FIX" marker in
pkg/analysis/ir/canonicalizer.goregarding the impurity oflen()andcap()for Maps and Channels. The analysis confirmed the logic was already correctly implemented. The marker was updated to a note to resolve the flagged item, and a regression test was added topkg/analysis/ir/ir_test.goto guarantee thatlenandcapon channels are treated as impure and not hoisted during canonicalization, matching the behavior for maps.PR created automatically by Jules for task 8490562561725051731 started by @xkilldash9x