fix(release-notes): let Artur sync acknowledge known-in-source drift - #300
Conversation
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Important Review available on request
Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out. Comment |
Problem
The "Sync Approved Artur Release" workflow refuses to build the Artur snapshot for 2026.08.3. Its drift guard (
findUnbackportedDestinationCommits) flags Arthur commit6cf7474224eaeb97aca9e77a6a4bedb26045df01(PR #23, "support investigate keyword schema") as an application commit missing from the source snapshot.This is a false positive. That commit removes
maxItemsfromKEYWORDS_SCHEMAinapps/worker/src/workflows/blocks/investigate.ts. Sourcemainalready omitsmaxItemsfrom that schema, so the end state is identical: overwriting Arthur with the source snapshot preserves the change rather than reverting it. The patch-id guard flags it only because no source commit in the selected range carries that exact patch (source dropped it earlier / never had it).Change
sync-arturnow reads an optionalscripts/release-notes/acknowledged-drift.jsonfrom--source-main(live main). Any listed commit that the guard flags is excluded from the fatal check and recorded underacknowledgedDriftin the sync result for audit. Commits that are not listed still hard-fail exactly as before.The one acknowledged entry documents why #23 is safe. Tracked under AIW-281.
Safety
--source-main(live main), so it is reviewed here. The snapshot is frozen at the approvedtargetSourceCommit, so this tooling change is not shipped into the Arthur snapshot.Verification
pnpm typecheck:release-notescleanpnpm test:release-notes16/16 pass, incl. two new cases: acknowledged drift proceeds + records; unacknowledged drift still blocks.