Skip to content

fix(release-notes): let Artur sync acknowledge known-in-source drift - #300

Merged
outof-place merged 1 commit into
mainfrom
fix/artur-sync-acknowledge-drift
Aug 17, 2026
Merged

fix(release-notes): let Artur sync acknowledge known-in-source drift#300
outof-place merged 1 commit into
mainfrom
fix/artur-sync-acknowledge-drift

Conversation

@outof-place

Copy link
Copy Markdown
Collaborator

Problem

The "Sync Approved Artur Release" workflow refuses to build the Artur snapshot for 2026.08.3. Its drift guard (findUnbackportedDestinationCommits) flags Arthur commit 6cf7474224eaeb97aca9e77a6a4bedb26045df01 (PR #23, "support investigate keyword schema") as an application commit missing from the source snapshot.

This is a false positive. That commit removes maxItems from KEYWORDS_SCHEMA in apps/worker/src/workflows/blocks/investigate.ts. Source main already omits maxItems from that schema, so the end state is identical: overwriting Arthur with the source snapshot preserves the change rather than reverting it. The patch-id guard flags it only because no source commit in the selected range carries that exact patch (source dropped it earlier / never had it).

Change

sync-artur now reads an optional scripts/release-notes/acknowledged-drift.json from --source-main (live main). Any listed commit that the guard flags is excluded from the fatal check and recorded under acknowledgedDrift in the sync result for audit. Commits that are not listed still hard-fail exactly as before.

The one acknowledged entry documents why #23 is safe. Tracked under AIW-281.

Safety

  • Acknowledging one full SHA suppresses only that exact commit; any other real un-backported commit still blocks the sync (covered by a test).
  • The data file is read from --source-main (live main), so it is reviewed here. The snapshot is frozen at the approved targetSourceCommit, so this tooling change is not shipped into the Arthur snapshot.

Verification

  • pnpm typecheck:release-notes clean
  • pnpm test:release-notes 16/16 pass, incl. two new cases: acknowledged drift proceeds + records; unacknowledged drift still blocks.

@chatgpt-codex-connector

Copy link
Copy Markdown

Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits.
Credits must be used to enable repository wide code reviews.

@vercel

vercel Bot commented Aug 17, 2026

Copy link
Copy Markdown

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Actions Updated (UTC)
ai-workflow-app-dashboard Ready Ready Preview Aug 17, 2026 10:09am

Request Review

@coderabbitai

coderabbitai Bot commented Aug 17, 2026

Copy link
Copy Markdown

Important

Review available on request

  • 🔍 Trigger review

Reviews should be triggered manually for repositories with fewer than 10 stars. Select Trigger review above or comment @coderabbitai review to review the latest changes. For a full review, comment @coderabbitai full review.

⚙️ Run configuration

Configuration used: Repository UI

Review profile: CHILL

Plan: Pro Plus

Run ID: 4fd36d68-93e1-43cb-b4ed-69c406407ac4


Thanks for using CodeRabbit! It's free for OSS, and your support helps us grow. If you like it, consider giving us a shout-out.

❤️ Share

Comment @coderabbitai help to get the list of available commands.

@outof-place
outof-place merged commit 20f42df into main Aug 17, 2026
4 checks passed
@outof-place
outof-place deleted the fix/artur-sync-acknowledge-drift branch August 17, 2026 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant