test(worker): bind sandbox mock statically - #355
Merged
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
|
Codex usage limits have been reached for code reviews. Please check with the admins of this repo to increase the limits by adding credits. |
|
Important
This repository does not receive automatic reviews because it has fewer than 10 stars. ⚙️ Run configurationConfiguration used: Repository UI Review profile: CHILL Plan: Pro Plus Run ID: Comment |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Follow-up to #354 / AWP-125.
Main CI run 33173321742 showed that the top-level dynamic test import introduced in #354 could still lose the Vitest mock boundary under the full suite: one timeout test never reached its stdout spy and the following replay test reached the real Vercel Sandbox OIDC path.
This surgical test-only patch restores the static
Sandboximport while retaining #354's deferred rejection/drain cleanup. Vitest hoistsvi.mock, so runtime dynamic imports inpoll-agent.tsresolve against the statically established mocked module.Verification:
poll-agent.test.ts: 21/21, repeated 20/20 sequentially (420 tests)git diff --check: passNo production runtime file changes.