Change AST to match the functionality of the Driver#284
Merged
KyrylR merged 1 commit intoBlockstreamResearch:dev/importsfrom Apr 21, 2026
Merged
Conversation
KyrylR
reviewed
Apr 15, 2026
|
|
||
| mod linearization; | ||
| mod resolve_order; | ||
| pub mod resolve_order; |
Collaborator
There was a problem hiding this comment.
Suggested change
| pub mod resolve_order; | |
| pub(crate) mod resolve_order; |
?
LesterEvSe
force-pushed
the
feature/imports-with-ast
branch
2 times, most recently
from
5db3887 to
8924e31
Compare
LesterEvSe
force-pushed
the
feature/imports-with-ast
branch
2 times, most recently
from
a56022e to
539cf0a
Compare
LesterEvSe
force-pushed
the
feature/imports-with-ast
branch
from
539cf0a to
e1cd84e
Compare
Collaborator
|
|
Collaborator
|
Could we document that |
LesterEvSe
force-pushed
the
feature/imports-with-ast
branch
from
e1cd84e to
af536d0
Compare
KyrylR
reviewed
Apr 21, 2026
Comment on lines
+589
to
+592
| assert_eq!( | ||
| self.file_id, MAIN_MODULE, | ||
| "The 'main' function must be defined in the entry point file" | ||
| ); |
Collaborator
There was a problem hiding this comment.
Not sure if it is a good idea to panic here
LesterEvSe
force-pushed
the
feature/imports-with-ast
branch
from
af536d0 to
0fc6ca3
Compare
KyrylR
approved these changes
Apr 21, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
DependencyGraphto prevent the usage of magic numbers.AST currently has some issues with processing source files properly, so they are not used and have been deleted along with the
ResolvedFilestructure.I hope this will be fixed when the
ErrorCollectoris recoded to support multiple files better.