Skip to content

fix: simplex test runs non-simplex test when no args provided#56

Open
topologoanatom wants to merge 2 commits intoBlockstreamResearch:devfrom
topologoanatom:fix/smplx-test-exclusive
Open

fix: simplex test runs non-simplex test when no args provided#56
topologoanatom wants to merge 2 commits intoBlockstreamResearch:devfrom
topologoanatom:fix/smplx-test-exclusive

Conversation

@topologoanatom
Copy link
Copy Markdown

@topologoanatom topologoanatom commented Apr 21, 2026

Fixes #53

@topologoanatom topologoanatom marked this pull request as ready for review April 22, 2026 11:22
Comment thread crates/cli/src/commands/test.rs Outdated
@topologoanatom topologoanatom force-pushed the fix/smplx-test-exclusive branch from 877876d to 422ae0a Compare April 22, 2026 14:37
@topologoanatom
Copy link
Copy Markdown
Author

Currently the code uses a suffix as a marker for simplex-related tests. This is better from a UX perspective, but it somewhat limits our ability to utilize the underlying cargo test filtering functionality. For example, running simplex test cold would not find cold_path_spend, since it would look for a test named cold_smplx rather than doing a substring match on the base name.

This issue could be solved by using a prefix as the marker instead, at the cost of slightly worse UX.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants