Readme update -mark_safe usage in admin views#215
Merged
Conversation
Bogdanp
approved these changes
Feb 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
We received a security report in #214 (attached below) flagging the use of
mark_safe()inTaskAdminfor rendering message details and tracebacks. The concern is that if task arguments or exception messages contain untrusted user input, this could be a stored XSS vector when viewed in the Django admin.Assessment
This is a valid use case for
mark_safe. We're rendering structured data inside<pre>tags in a trusted admin-only context. The risk is low for most deployments since the Django admin is restricted to staff users. That said, applications that process untrusted input through Dramatiq tasks (e.g. webhook payloads, user-submitted data) could be affected.Proposed approach
Rather than changing the library's default behavior, this PR:
mark_safeusageTaskAdminwith aSafeTaskAdminthat usesformat_html()to auto-escape interpolated valuesIf this turns out to be a common concern, we can merge the workaround into the codebase as the default behavior in a future release.
WDYT?
django-dramatiq-security-disclosure.md