fix: address PR review comments for docker-compose CI workflow - #100
Closed
RonTuretzky wants to merge 23 commits into
Closed
fix: address PR review comments for docker-compose CI workflow#100RonTuretzky wants to merge 23 commits into
RonTuretzky wants to merge 23 commits into
Conversation
- Add commonware-avs-node services (1-3) using ghcr.io/breadchaincoop/commonware-avs-node:v0.1.0 - Add commonware-avs-router service using ghcr.io/breadchaincoop/commonware-avs-router:dev - Configure services with proper environment variables and networking - Add orchestrator_with_g2.json config file for BLS key management - Map ports to 4000-4003 to avoid conflicts with local development - Set up volume mounts for keys and configuration files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add setup-node-keys.sh script to generate properly formatted BLS keys - Add README_DOCKER.md with complete setup instructions - Script extracts keys from eigenlayer-generated files and formats them for nodes - Documentation covers setup, troubleshooting, and usage
- Add hostname resolution using ToSocketAddrs in router's main.rs - Update docker-compose.yml to use debug-v2 router image with hostname support - Configure public_orchestrator.json to use Docker service name 'router' - Add pull_policy: always to node services for consistent PR-55 image updates - Remove accidentally cloned commonware-avs-node directory This allows the router to resolve Docker service names (like node-1:3001) to IP addresses, fixing the AddrParseError(Socket) issues when using Docker Compose networking. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Update eigenlayer and node images from PR versions to dev - Enable restart policy for all node services and router - Restore platform specification for router service - Remove debug println statements from src/main.rs - Fix duplicate RUST_BACKTRACE environment variable Changes made per code review comments to standardize on dev images and enable proper service restart policies. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add pull_request trigger to Docker CI/CD workflow for main and dev branches - Implement PR-specific tagging using pr-<number> format - Update signer service to depend on eigenlayer completion instead of ethereum start - Maintain platform specification for router service This enables automatic Docker image builds for pull requests, making it easier to test PR changes using the ghcr.io registry with pr-<number> tags. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Apply cargo fmt to fix formatting issues (trailing whitespace) - Fix clippy uninlined_format_args warnings by using inline format strings - Remove commonware-avs-node from rust-ci.yml matrix build - Simplify CI workflow to only check this repository All clippy warnings have been resolved and the code now passes cargo clippy -- -D warnings. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Add allows to CI clippy command for warnings that come from: - Auto-generated binding files (unused_attributes, unused_variables) - Existing test code format strings (uninlined_format_args) This ensures CI passes without modifying auto-generated files or requiring changes to existing test code. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Reverted the format string change from commit 208c77e to keep the original code unchanged. The clippy warning for uninlined_format_args is now allowed in the CI configuration instead. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Create a new CI workflow that uses docker-compose to test the full stack instead of the manual setup in local-test.yml. Features: - Builds router image locally for testing - Pulls required images from GitHub Container Registry - Generates test BLS keys for operators - Starts all services using docker-compose - Waits for EigenLayer setup to complete - Verifies all services are running - Checks basic connectivity and health - Collects comprehensive logs on failure - Proper cleanup after test completion This provides a more realistic test environment that matches how the services will actually be deployed and interact. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
Enhanced the docker-compose CI test to verify the core functionality: - Check initial counter state from router logs - Wait for aggregation cycle (30+ seconds) - Verify counter has incremented - Check for successful signature aggregation - Verify each node is participating and signing messages This ensures the AVS is not just running but actually performing its intended counter increment functionality with proper BLS signature aggregation across all nodes. 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Use example.env as base and properly set FORK_URL to fix ethereum error - Wait for EigenLayer to generate BLS keys instead of creating them manually - Remove flaky P2P connectivity check that relied on log patterns - Increase timeout to 300 seconds matching local-test workflow - Model setup steps after local-test workflow for consistency The workflow now properly: 1. Copies example.env and configures it for LOCAL mode 2. Sets FORK_URL for Holesky forking (fixes ethereum startup error) 3. Waits for EigenLayer to generate operator BLS keys 4. Uses a more robust service status check 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add LST_CONTRACT_ADDRESS and all required Holesky contract addresses to .env generation - Fix Docker build error by creating dummy scripts directory during pre-build phase - These changes address the eigenlayer service startup failure and cargo build errors 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Support using repository secret RPC_URL for fork URL if available - Add validation for counter contract address from deployment file - Ensure operator_keys directory exists before eigenlayer setup 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
1. Remove extra allow flags from rust-ci clippy command
- Now using only: cargo clippy --all-targets --all-features -- -D warnings
2. Use repository secret for RPC_URL if available
- Falls back to public Holesky RPC if secret not set
- Uses ${{ secrets.RPC_URL }} for FORK_URL configuration
3. Fix .nodes directory handling
- CI creates directory structure as needed
- .nodes is gitignored so doesn't need .gitkeep
4. Replace log parsing with smart contract reads for counter test
- Directly reads counter value from blockchain using eth_call
- Uses function signature 0x8381f58a for number() method
- More reliable than parsing logs
The CI now properly reads the counter state directly from the smart contract
and uses repository secrets for RPC URLs when available.
🤖 Generated with [Claude Code](https://claude.ai/code)
Co-Authored-By: Claude <noreply@anthropic.com>
- Simplified sed commands to just remove comment character instead of full replacement - Removed flaky log checks for signature aggregation and node participation - Extended wait time to 5 aggregation cycles (150 seconds) for more reliable testing - Added explanatory comment for Dockerfile workspace member dummy files 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Add creation of config/config.json from example in CI workflow - This file is required by the eigenlayer service for proper startup - Fixes "Is a directory (os error 21)" error in eigenlayer container 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
- Fix jq parsing error when checking container status - Docker compose ps --format json returns an object, not an array - Use ".State // empty" instead of ".[0].State" for proper parsing 🤖 Generated with [Claude Code](https://claude.ai/code) Co-Authored-By: Claude <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
🤖 Generated with Claude Code