Add BLS key check to local testing workflow - #115
Closed
RonTuretzky wants to merge 1 commit into
Closed
Conversation
This commit adds BLS key validation to test if keys were valid before the eigenlayer-bls-local submodule was deprecated in favor of Docker images. The verification checks that BLS keys are at least 70 characters (expecting ~77 digits for BN254 curve). Testing on branch: test-before-deprecation Based on commit: 1f00abb (before deprecation merge)
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Background
The integration tests have been updated to include a check for valid BLS keys. This change ensures that the local testing workflow also performs this validation.
Changes
.github/workflows/local-test.yml:testacc1.private.bls.key.json,testacc2.private.bls.key.json, andtestacc3.private.bls.key.jsonin the.nodes/operator_keys/directory.jqto extract theprivateKeyvalue and verifies its length. A length less than 70 characters is considered an error, as BLS keys on the BN254 curve are expected to be around 77 digits.test-before-deprecationbranch.Testing