Skip to content

Add BLS key check to local testing workflow - #115

Closed
RonTuretzky wants to merge 1 commit into
devfrom
test-before-deprecation
Closed

Add BLS key check to local testing workflow#115
RonTuretzky wants to merge 1 commit into
devfrom
test-before-deprecation

Conversation

@RonTuretzky

Copy link
Copy Markdown
Contributor

Background

The integration tests have been updated to include a check for valid BLS keys. This change ensures that the local testing workflow also performs this validation.

Changes

  • Modified .github/workflows/local-test.yml:
    • Added a new job step titled "Verify BLS key files".
    • This step iterates through testacc1.private.bls.key.json, testacc2.private.bls.key.json, and testacc3.private.bls.key.json in the .nodes/operator_keys/ directory.
    • It checks for the existence of each file.
    • It uses jq to extract the privateKey value and verifies its length. A length less than 70 characters is considered an error, as BLS keys on the BN254 curve are expected to be around 77 digits.
    • The workflow will exit with an error code if any key file is missing or if a private key is too short.
    • The workflow trigger has been updated to include the test-before-deprecation branch.

Testing

  • Ensure the local testing workflow runs successfully with the new BLS key verification step.
  • Manually inspect the output to confirm correct key file detection and length validation.

This commit adds BLS key validation to test if keys were valid before the
eigenlayer-bls-local submodule was deprecated in favor of Docker images.
The verification checks that BLS keys are at least 70 characters (expecting
~77 digits for BN254 curve).

Testing on branch: test-before-deprecation
Based on commit: 1f00abb (before deprecation merge)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant