fix: World reloading issue for barrels - #198
Draft
Thorinwasher wants to merge 1 commit into
Draft
Conversation
Thorinwasher
marked this pull request as draft
March 9, 2026 08:49
|
I traced #197 beyond the debug logging in this draft. The world listener exists but is never registered, and once registered the current full-save path would delete persisted barrels for worlds that are not loaded. #223 contains the actual fix: listener registration, reload on world load, save/unregister on unload, preservation of unloaded-world records during autosave, explicit deletion for genuinely destroyed barrels, and the Folia no-event path. It also builds successfully against current Since this PR only adds diagnostics and is now conflicting, I recommend superseding it with #223. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #197
Currently just includes debug messages.