Skip to content

fix: World reloading issue for barrels - #198

Draft
Thorinwasher wants to merge 1 commit into
masterfrom
fix/reloading-world-barrel-issue
Draft

fix: World reloading issue for barrels#198
Thorinwasher wants to merge 1 commit into
masterfrom
fix/reloading-world-barrel-issue

Conversation

@Thorinwasher

Copy link
Copy Markdown
Contributor

Fixes #197

Currently just includes debug messages.

@Minecraft0122

Copy link
Copy Markdown

I traced #197 beyond the debug logging in this draft. The world listener exists but is never registered, and once registered the current full-save path would delete persisted barrels for worlds that are not loaded.

#223 contains the actual fix: listener registration, reload on world load, save/unregister on unload, preservation of unloaded-world records during autosave, explicit deletion for genuinely destroyed barrels, and the Folia no-event path. It also builds successfully against current master.

Since this PR only adds diagnostics and is now conflicting, I recommend superseding it with #223.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Unloading the world causes the barrel settings to disappear.

2 participants