Draft
Conversation
- Introduced new API methods for retrieving rewards and voter capabilities in the Viction blockchain. - Added support for epoch-based operations and improved network information structure. - Implemented caching for block hashes and added functionality to check if two blocks are on the same path. - Updated Viction configuration to include limit time finality. - Enhanced comments and documentation for clarity.
- Implemented methods to retrieve attestors pairs and penalties at checkpoint for both hash and block number. - Enhanced error handling in existing reward retrieval methods to improve robustness. - Updated API to reflect new functionalities, ensuring better integration with the Viction blockchain.
- Removed obsolete methods for retrieving block hashes from cache and checking block paths. - Updated viction.json to include new block parameters for TomoX and lending features. - Simplified the types.go file by eliminating the EpochNumber type and related JSON unmarshalling logic.
… field from VictionConfig - Updated comments in the GetBlockByNumber function for better clarity and consistency. - Removed the LimitTimeFinality field from the VictionConfig struct as it is no longer needed.
- Reformatted the viction.json file to ensure consistent indentation and structure. - No functional changes were made; this update improves readability and maintainability of the configuration file.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Description:
Root Cause:
Resolution:
EthAPIBackendand ensures Viction RPCs are registeredposvRPC API to support PoSV-related queries