Get Paid: unified transaction card - #152
Draft
BullishNode wants to merge 1 commit into
Draft
Conversation
There is no separate 'payment' — only the invoice — so the transaction
card stops linking out to a second screen and becomes the single place a
merchant reads everything about an entry, for every product (Lightning
address, invoices, Payment Page, POS).
- View-invoice button removed; the card renders every field of the
history contract: receipt id (copyable, never presented as a chain
txid), settlement kind stated explicitly ('Settled as: Bitcoin' instead
of an absent section), per-leg network, and the fiat-conversion
override with all five 0.3 reasons — ambiguous_create now mapped and
worded instead of funneling to unknown
- invoice facts merged in via the invoices facade (locator-guarded,
fail-silent): status with supporting lines only when they add
information, face amount, pricing, paid/remaining/overpaid, tolerance,
rate locked until, absolute expiry, paid via/at, accepted rails, and a
compact per-event payment history
- payer instructions render last, collapsed: lightning invoice,
addresses, BIP21, per-rail payer amounts, quote rails, and the live
payer quote rate — labelled distinctly from the R1 reference and R2
executed rates so the three can never be misread
- organized into titled sections in merchant-priority order; every fact
appears exactly once; long values truncate in place and copy in full;
empty sections render nothing
- shared invoice copy moved to the invoices public boundary
(invoice_copy.dart) so Get Paid reuses it without cross-feature reach
Gates: analyze --fatal-infos clean; 516 tests green (21 new card tests).
BullishNode
force-pushed
the
getpaid-2-56-getpaid-transaction-card
branch
from
July 28, 2026 14:22
6d60bb2 to
b5c8669
Compare
BullishNode
force-pushed
the
getpaid-2-55-nostr-keys-ux
branch
from
July 28, 2026 14:22
727abe8 to
bb3cff0
Compare
This was referenced Jul 28, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stacked on the Nostr keys PR. One card per Get Paid entry, showing everything the server knows — there is no separate "payment" object, only the invoice, so the card no longer links out to a second screen.
ambiguous_createnow mapped and worded instead of falling through to "unknown").Reference doc for every field and value:
GETPAID_TRANSACTION_CARD_REFERENCE.md(kept out of the repo).