Lightning Address activation: honest timeout and a named wait - #160
Draft
BullishNode wants to merge 2 commits into
Draft
Lightning Address activation: honest timeout and a named wait#160BullishNode wants to merge 2 commits into
BullishNode wants to merge 2 commits into
Conversation
…tus unknown" A claim that timed out — tonight's case, where the server took longer than ~15s and nginx logged the client disconnect — surfaced as "Status Unknown: registration may have succeeded. Check status before trying again." That reads as though the app knows something it does not: no answer came back at all. Map a timeout or an unreachable server to their own outcome, stating that the server did not answer, that nothing was claimed, and offering a retry of the claim itself rather than a status re-read. A garbled answer stays genuinely uncertain, which is what that surface was for. If the claim did reach the server, the retry still lands correctly: the NymAlreadyAssigned reconciliation already handles that.
After a successful activation the app pushes this editor, which cannot draw anything until the server answers with the product's current payout configuration. That read was covered by a bare CircularProgressIndicator — the only one in this flow, and unlike the shimmer skeleton every other Get Paid screen uses — with nothing said about what was being waited for. On a slow server that reads as a hang between the success screen and the chooser. Use the same skeleton the Lightning Address, Donation Page and Point of Sale screens use while they read their own server state, and state what the wait is.
This was referenced Jul 29, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Owner QA findings from the live walkthrough, Lightning Address activation feedback. Stacked on the advanced-settings PR.
NymAlreadyAssignedreconciliation still resolves it on retry.Gates: analyze clean, lightning_address 102 + fiat_settlement 45 green, full suite 2360 on the stack tip.