stack/getpaid 2 64 btcpay completeness - #232
Draft
BullishNode wants to merge 2 commits into
Draft
Conversation
Recovery asks for the same network-specific posture initial BTCPay pairing applies (Bitcoin auto-sweep off, Liquid on) through the if-missing defaults write, so a behavior the wallet already records survives recovery. The manifest carries no behavior flags, so those defaults are all the restore path has in hand. Filling the two switches independently could still pair a recorded hide-on-home with a default auto-sweep of off — the combination the auto-sweep / hide-on-home rule exists to refuse. The filled pair now goes through resolveWalletBehaviorChange, so a restored hidden wallet whose auto-sweep lands off comes back visible, and a deliberate toggle afterwards still changes and persists. Closes #135
BTCPay's settings screen rendered its own ungated hide-on-home switch, so a tap the repository rule refuses looked accepted until the reload put the old value back with no explanation. Extract the switch pair the shared Get Paid card grew in #159 into WalletBehaviorSwitches, which owns the coupling gate and the one copy stating what hiding depends on, and render both surfaces through it. Each surface keeps its own labels; neither can state the rule differently. BTCPay's optimistic update now resolves the requested toggle the way the write will, so turning auto-sweep off unhides in place rather than on the next load. Closes #162
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬