stack/getpaid 2 65 arch fixes - #233
Draft
BullishNode wants to merge 2 commits into
Draft
Conversation
Move the shared advanced-settings sheet, wallet-behavior card, nym claim step, name choice block, and link/QR block from the private UI directory to the feature public surface. They remain Get Paid business UI and do not move into core. Publish GetPaidWalletBehavior and GetPaidWalletProduct from a stable domain type instead of an internal use-case file, and make the facade callback-injected like its sibling facades. Give Lightning Address, Donation Page, and POS feature-owned wallet-behavior wrapper use cases so their Cubits consume only local orchestration and map foreign operational failures at the boundary. Preserve behavior and logging, verify provider and consumer wiring, and update FEATURES.md to reflect the actual product dependencies.
Move the five hub integrations behind Get Paid-owned use cases. Each use case maps foreign outcomes into Get Paid types, keeps feature entities out of dashboard state, owns the mainnet settlement gate, and makes every dependency explicit. Move invoice detail loading out of the screen and into a typed cubit with initial, loading, data, and failure states. A failed read now states that invoice details are unavailable instead of rendering the receipt as if it had no invoice. Use only Bullnym's public facade, expose CurrencyText through Bitcoin Price's public surface, and project settlement badges into Get Paid-owned state. Preserve all other behavior, cover the boundaries with use case, cubit, and boot tests, update FEATURES.md, and document the resulting architecture.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬