stack/getpaid 2 67 d30 payment admission - #235
Draft
BullishNode wants to merge 16 commits into
Draft
Conversation
Get Paid transaction history contains only authenticated payment evidence, so an invoice-backed history row can never be an unpaid payer surface. Remove the unreachable payer-instruction branch and its admission, quote, and payment-payload projection. Keep the ordinary Invoices flow as the owner of unpaid invoice payment actions, while the Get Paid detail remains a read-only merchant receipt. Retain regression coverage proving that stale public payloads cannot become receipt actions and remove the now-dead localization keys.
Put every changed comment sentence on one continuous source line as required by AGENTS.md. Correct the Donation Page and POS wallet-resolution descriptions to name manifest reservation ids, and correct the wizard persistence description to name the unified wallet-backup facade. This commit changes comments and formatter-adjacent layout only.
Delete the optional test-double parameters left behind when the receipt lookup became intrinsically read-only.
Describe invoice-backed and Lightning Address receipts separately instead of implying that every receipt has an invoice.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Stack created with GitHub Stacks CLI • Give Feedback 💬