Skip to content

fix: deletion UI consistency fixed #872

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
devxdebanjan wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: deletion UI consistency fixed #872

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
8dcc448
fix: Deleted variable margin to give a uniform fixed layout in Alarms…
devxdebanjan Mar 10, 2026
5def53c
cleanup: Animatedcontainer and isAnyAlarmHolded variable cleaned up d…
devxdebanjan Mar 10, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 0 additions & 2 deletions lib/app/modules/home/controllers/home_controller.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -67,7 +67,6 @@ class HomeController extends GetxController {

RxBool isSortedAlarmListEnabled = true.obs;
RxBool inMultipleSelectMode = false.obs;
RxBool isAnyAlarmHolded = false.obs;
RxBool isAllAlarmsSelected = false.obs;
RxInt numberOfAlarmsSelected = 0.obs;
Pair<List<AlarmModel>, List<RxBool>> alarmListPairs = Pair([], []);
Expand Down Expand Up @@ -681,7 +680,6 @@ class HomeController extends GetxController {

// Closing the multiple select mode
inMultipleSelectMode.value = false;
isAnyAlarmHolded.value = false;
isAllAlarmsSelected.value = false;

numberOfAlarmsSelected.value = 0;
Expand Down
26 changes: 1 addition & 25 deletions lib/app/modules/home/views/home_view.dart
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -271,8 +271,6 @@ class HomeView extends GetView<HomeController> {
// On pressing the close button, we're closing the multiple select mode, and clearing the select alarm set
controller.inMultipleSelectMode
.value = false;
controller.isAnyAlarmHolded
.value = false;
controller.isAllAlarmsSelected
.value = false;
controller.numberOfAlarmsSelected
Expand Down Expand Up @@ -420,7 +418,6 @@ class HomeView extends GetView<HomeController> {

// Closing the multiple select mode
controller.inMultipleSelectMode.value = false;
controller.isAnyAlarmHolded.value = false;
controller.isAllAlarmsSelected.value = false;
controller.numberOfAlarmsSelected.value = 0;
controller.selectedAlarmSet.clear();
Expand Down Expand Up @@ -609,9 +606,6 @@ class HomeView extends GetView<HomeController> {
controller
.inMultipleSelectMode
.value = true;
controller
.isAnyAlarmHolded
.value = true;

// Assigning the alarm list pairs to list of alarms and list of isSelected all equal to false initially
controller
Expand All @@ -626,24 +620,7 @@ class HomeView extends GetView<HomeController> {

Utils.hapticFeedback();
},
onLongPressEnd: (details) {
controller
.isAnyAlarmHolded
.value = false;
},
child: AnimatedContainer(
duration: const Duration(
milliseconds: 600,
),
curve: Curves.easeInOut,
margin: EdgeInsets.all(
controller
.isAnyAlarmHolded
.value
? 10
: 0,
),
child: Center(
child: Center(
child: Padding(
padding:
const EdgeInsets
Expand Down Expand Up @@ -1064,7 +1041,6 @@ class HomeView extends GetView<HomeController> {
),
),
),
),
)
: SizedBox();
},
Expand Down