feat: Replace collapsible search panels with always-visible inline filters#3325
Draft
kbeaugrand with Copilot wants to merge 1 commit into
Draft
feat: Replace collapsible search panels with always-visible inline filters#3325kbeaugrand with Copilot wants to merge 1 commit into
kbeaugrand with Copilot wants to merge 1 commit into
Conversation
Copilot
AI
changed the title
[WIP] Add filters on table columns instead of search panel
feat: Replace collapsible search panels with always-visible inline filters
Mar 5, 2026
…list pages Co-authored-by: kbeaugrand <9513635+kbeaugrand@users.noreply.github.com>
Metal-Mighty
force-pushed
the
copilot/add-filters-to-table-columns
branch
from
April 16, 2026 11:56
a3156fd to
010832f
Compare
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3325 +/- ##
=======================================
Coverage 81.25% 81.25%
=======================================
Files 376 376
Lines 14428 14428
Branches 1235 1235
=======================================
Hits 11723 11723
Misses 2322 2322
Partials 383 383 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
Comment on lines
+22
to
+74
| @foreach (DeviceTagDto tag in TagList) | ||
| { | ||
| if (tag.Searchable) | ||
| { | ||
| <MudItem xs="12" md="6"> | ||
| <MudTextField @bind-Value="searchID" Placeholder="DeviceID / DeviceName" id="searchID"></MudTextField> | ||
| <MudTextField @bind-Value="searchTags[tag.Name]" Placeholder="@tag.Label"></MudTextField> | ||
| </MudItem> | ||
| @foreach (DeviceTagDto tag in TagList) | ||
| } | ||
| } | ||
|
|
||
| <MudItem xs="12" md="6"> | ||
| <MudSelect T="LabelDto" Label="Labels" MultiSelection="true" @bind-SelectedValues="selectedLabels" | ||
| MultiSelectionTextFunc="@(new Func<List<string>, string>(GetMultiSelectionText))" | ||
| Variant="Variant.Outlined"> | ||
| @foreach (var label in labels) | ||
| { | ||
| if (tag.Searchable) | ||
| { | ||
| <MudItem xs="12" md="6"> | ||
| <MudTextField @bind-Value="searchTags[tag.Name]" Placeholder="@tag.Label"></MudTextField> | ||
| </MudItem> | ||
| } | ||
| <MudSelectItem T="LabelDto" Value="@label"> | ||
| <MudChip Text="@label.Name" Color="Color.Primary" Style="@($"background-color: {label.Color};")" /> | ||
| </MudSelectItem> | ||
| } | ||
|
|
||
| <MudItem xs="12" md="6"> | ||
| <MudSelect T="LabelDto" Label="Labels" MultiSelection="true" @bind-SelectedValues="selectedLabels" | ||
| MultiSelectionTextFunc="@(new Func<List<string>, string>(GetMultiSelectionText))" | ||
| Variant="Variant.Outlined"> | ||
| @foreach (var label in labels) | ||
| { | ||
| <MudSelectItem T="LabelDto" Value="@label"> | ||
| <MudChip Text="@label.Name" Color="Color.Primary" Style="@($"background-color: {label.Color};")" /> | ||
| </MudSelectItem> | ||
| } | ||
| </MudSelect> | ||
| </MudItem> | ||
|
|
||
| <MudItem xs="12" md="6"> | ||
| <MudAutocomplete T="DeviceModelDto" | ||
| id="@nameof(DeviceModelDto.ModelId)" | ||
| @bind-Value="Model" | ||
| SearchFunc="@Search" | ||
| Label="Model" | ||
| Dense=true | ||
| For=@(() => this.Model) | ||
| Variant="Variant.Outlined" | ||
| ToStringFunc="@(x => x?.Name)" | ||
| ResetValueOnEmptyText=true | ||
| Immediate=true | ||
| Clearable=true | ||
| CoerceText=true | ||
| CoerceValue=false> | ||
| <ItemTemplate> | ||
| @context.Name | ||
| <MudText Typo="Typo.subtitle1" Class="mud-input-helper-text"> | ||
| @((!string.IsNullOrEmpty(@context.Description) && @context.Description.Length > 100) ? @context.Description.Substring(0, 100) + "..." : @context.Description) | ||
| </MudText> | ||
| </ItemTemplate> | ||
| </MudAutocomplete> | ||
| </MudItem> | ||
| <MudGrid> | ||
| <MudItem sm="12" md="6"> | ||
| <MudText>Status</MudText> | ||
| <MudRadioGroup @bind-SelectedOption="@searchStatus" Style="display:flex;align-items:baseline" id="searchStatus"> | ||
| <MudItem md="4" sm="12"> | ||
| <MudRadio Option=@("true") Color="Color.Primary" id="searchStatusEnabled">Enabled</MudRadio> | ||
| </MudItem> | ||
| <MudItem md="4" sm="12"> | ||
| <MudRadio Option=@("false") Color="Color.Primary" id="searchDisabled">Disabled</MudRadio> | ||
| </MudItem> | ||
| <MudItem md="4" sm="12"> | ||
| <MudRadio Option=@("") Color="Color.Secondary" id="searchStatusAll">All</MudRadio> | ||
| </MudItem> | ||
| </MudRadioGroup> | ||
|
|
||
| </MudSelect> | ||
| </MudItem> | ||
|
|
||
| <MudItem xs="12" md="6"> | ||
| <MudAutocomplete T="DeviceModelDto" | ||
| id="@nameof(DeviceModelDto.ModelId)" | ||
| @bind-Value="Model" | ||
| SearchFunc="@Search" | ||
| Label="Model" | ||
| Dense=true | ||
| For=@(() => this.Model) | ||
| Variant="Variant.Outlined" | ||
| ToStringFunc="@(x => x?.Name)" | ||
| ResetValueOnEmptyText=true | ||
| Immediate=true | ||
| Clearable=true | ||
| CoerceText=true | ||
| CoerceValue=false> | ||
| <ItemTemplate> | ||
| @context.Name | ||
| <MudText Typo="Typo.subtitle1" Class="mud-input-helper-text"> | ||
| @((!string.IsNullOrEmpty(@context.Description) && @context.Description.Length > 100) ? @context.Description.Substring(0, 100) + "..." : @context.Description) | ||
| </MudText> | ||
| </ItemTemplate> | ||
| </MudAutocomplete> | ||
| </MudItem> | ||
| <MudGrid> | ||
| <MudItem sm="12" md="6"> | ||
| <MudText>Status</MudText> | ||
| <MudRadioGroup @bind-SelectedOption="@searchStatus" Style="display:flex;align-items:baseline" id="searchStatus"> | ||
| <MudItem md="4" sm="12"> | ||
| <MudRadio Option=@("true") Color="Color.Primary" id="searchStatusEnabled">Enabled</MudRadio> | ||
| </MudItem> |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
The search panel across list pages was wrapped in a
MudExpansionPanel, requiring an extra click to access filters and consuming excessive vertical space when expanded.Changes
Removed
MudExpansionPanelwrapper from all search/filter components and list pages — filters are now always visible without user interaction:DeviceModelSearch.razorEdgeModelSearch.razorConcentratorSearch.razorDeviceListPage.razor(inline search panel)EdgeDeviceListPage.razor(inline search panel)Updated
DevicesListPageTests.cs— removed assertions checking for expansion panel CSS classes (.mud-expansion-panels,.mud-expand-panel) since the panel no longer exists; remaining test coverage is unaffectedAll element IDs are preserved, so existing test coverage continues to work without further changes.
What kind of change does this PR introduce?
Original prompt
💬 We'd love your input! Share your thoughts on Copilot coding agent in our 2 minute survey.