Fix data types in ice_boundary.F90 haloUpdate#1104
Merged
Conversation
Fix an oversight in the recent implementation of ice_boundary.F90 where the haloUpdates were communicating doubles instead of the native (dbl,real,int) type. Update the new boundary condition calculation to use consistent types and correct type conversion. This was fixed in generate_haloUpdates.sh then applied to the mpi and serial versions of ice_boundary.F90. Minor cleanup of ice_broadcast and ice_gather_scatter to make mpi variables consistent with respect to capitalization of names. These changes are bit-for-bit identical.
NickSzapiro-NOAA
approved these changes
Apr 23, 2026
NickSzapiro-NOAA
left a comment
NickSzapiro-NOAA
left a comment
Contributor
There was a problem hiding this comment.
Thanks @apcraig !!! And thanks @DeniseWorthen for finding the compiler warnings!
eclare108213
approved these changes
Apr 23, 2026
NickSzapiro-NOAA
pushed a commit
to NickSzapiro-NOAA/CICE
that referenced
this pull request
Apr 29, 2026
Fix an oversight in the recent implementation of ice_boundary.F90 where the haloUpdates were communicating doubles instead of the native (dbl,real,int) type. Update the new boundary condition calculation to use consistent types and correct type conversion. This was fixed in generate_haloUpdates.sh then applied to the mpi and serial versions of ice_boundary.F90. Minor cleanup of ice_broadcast and ice_gather_scatter to make mpi variables consistent with respect to capitalization of names. These changes are bit-for-bit identical.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
PR checklist
Fix data types in ice_boundary.F90 haloUpdate
apcraig
tested on derecho with 6 compilers, results are bit-for-bit. https://github.com/CICE-Consortium/Test-Results/wiki/cice_by_hash_forks#4c1a6da409371ee3a03c73ce0073b9ebab92653d
Fix an oversight in the recent implementation of ice_boundary.F90 where the haloUpdates were communicating doubles instead of the native (dbl,real,int) type. Update the new boundary condition calculation to use consistent types and correct type conversion. This was fixed in generate_haloUpdates.sh then applied to the mpi and serial versions of ice_boundary.F90.
Minor cleanup of ice_broadcast and ice_gather_scatter to make mpi variables consistent with respect to capitalization of names.
These changes are bit-for-bit identical.
Closes #1102