chore: Add RuboCop linting to development workflow#3
Merged
Conversation
Added RuboCop for code quality enforcement with auto-fix capabilities and CI integration. Technical changes: - Added rubocop ~> 1.60 gem to development dependencies - Created .rubocop.yml configuration targeting Ruby 3.0+ - Configured double-quote preference and frozen string literal enforcement - Disabled Style/OptionalBooleanParameter to maintain API backwards compatibility - Updated Rakefile to run both specs and rubocop in default task - Added separate lint job to GitHub Actions CI workflow - Updated README.md and CLAUDE.md with linting commands Benefits: - Enforces consistent Ruby style across codebase - Catches potential code quality issues early - CI fails on linting violations, ensuring clean PRs - All existing tests pass with zero linting offenses - Maintains full backwards compatibility with public API All 9 existing tests pass. Codebase has 0 linting offenses.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Changes
rubocop ~> 1.60gem to development dependencies.rubocop.ymlconfiguration (Ruby 3.0+, double quotes, frozen string literals)Rakefileto run both specs and rubocop by defaultBackwards Compatibility
Style/OptionalBooleanParametercop to maintain existing APITest Plan
bundle exec rspec- All tests passbundle exec rubocop- No offensesbundle exec rake- Runs both tests and linting successfully