Parse main repository license if not available in subdir (#540)#547
Open
marioscrock wants to merge 1 commit intoCLARIAH:devfrom
Open
Parse main repository license if not available in subdir (#540)#547marioscrock wants to merge 1 commit intoCLARIAH:devfrom
marioscrock wants to merge 1 commit intoCLARIAH:devfrom
Conversation
This was referenced Feb 3, 2026
c-martinez
reviewed
Mar 17, 2026
| """Returns a list of file items contained on the gitlab repo.""" | ||
| return self._fetchFilesFromPath(self.subdir) | ||
|
|
||
| def _fetchFilesFromPath(self, path): |
Collaborator
There was a problem hiding this comment.
I think variable path will clash with import from os import path.
Collaborator
|
Hi @marioscrock -- thanks for this PR (and sorry for the delayed in reacting to it) I think it looks fine, but it might be good to add a few tests. Do you think you could implement them (otherwise I can give it a go, but it might take me a while to get to it). |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Root folder is checked if the license file is not found in the provided subdir (see discussion in #540).